From: Felipe Balbi <balbi@ti.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
arnd@arndb.de, svadivu@ti.com, aneesh@ti.com,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Felipe Balbi <balbi@ti.com>
Subject: [PATCH] misc: emif: fix compilation error
Date: Fri, 25 May 2012 11:11:32 +0300 [thread overview]
Message-ID: <1337933492-25361-1-git-send-email-balbi@ti.com> (raw)
commit 99d3eccf (ARM: OMAP4/5: EMIF: Probe
Emif driver with initcall) introduced a compile
error by not removing module_init() when adding
postcore_initcall().
This problem would've been caught by just compiling
the driver as module.
Fix the issue by removing module_init() from the
driver.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/misc/emif.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/emif.c b/drivers/misc/emif.c
index 36fda8e..8725ea9 100644
--- a/drivers/misc/emif.c
+++ b/drivers/misc/emif.c
@@ -1663,7 +1663,6 @@ static void __exit emif_unregister(void)
}
postcore_initcall(emif_register);
-module_init(emif_register);
module_exit(emif_unregister);
MODULE_DESCRIPTION("TI EMIF SDRAM Controller Driver");
MODULE_LICENSE("GPL");
--
1.7.10.2
next reply other threads:[~2012-05-25 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 8:11 Felipe Balbi [this message]
2012-05-25 9:10 ` Shilimkar, Santosh
2012-05-25 9:29 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337933492-25361-1-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=aneesh@ti.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=svadivu@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®