From: Felipe Balbi <balbi@ti.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: Felipe Balbi <balbi@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
arnd@arndb.de, svadivu@ti.com, aneesh@ti.com
Subject: Re: [PATCH] misc: emif: fix compilation error
Date: Fri, 25 May 2012 12:29:28 +0300 [thread overview]
Message-ID: <20120525092927.GI3850@arwen.pp.htv.fi> (raw)
In-Reply-To: <CAMQu2gxeB1h9aieJU_WvCK2rPPLYkOVN8gw0i8xBm6yEPRNmHQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
On Fri, May 25, 2012 at 02:40:18PM +0530, Shilimkar, Santosh wrote:
> On Fri, May 25, 2012 at 1:41 PM, Felipe Balbi <balbi@ti.com> wrote:
> > commit 99d3eccf (ARM: OMAP4/5: EMIF: Probe
> > Emif driver with initcall) introduced a compile
> > error by not removing module_init() when adding
> > postcore_initcall().
> >
> > This problem would've been caught by just compiling
> > the driver as module.
> >
> > Fix the issue by removing module_init() from the
> > driver.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/misc/emif.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/misc/emif.c b/drivers/misc/emif.c
> > index 36fda8e..8725ea9 100644
> > --- a/drivers/misc/emif.c
> > +++ b/drivers/misc/emif.c
>
> This driver is in drivers/memory now and this patch is
> certainly not applicable. Looks like you might have seen
> this issue with the older, internal version of the driver.
could be.. I probably merged something I shouldn't on my master branch
;-)
Weird is that my master is built on top of v3.4... anyway.. forget about
this patch, sorry for the noise.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-25 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 8:11 Felipe Balbi
2012-05-25 9:10 ` Shilimkar, Santosh
2012-05-25 9:29 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525092927.GI3850@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=aneesh@ti.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=svadivu@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®