* [PATCH] dummies
@ 2012-05-29 3:13 Fabio Estevam
2012-06-05 12:47 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2012-05-29 3:13 UTC (permalink / raw)
To: linus.walleij; +Cc: shawn.guo, kernel, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
For mxs_defconfig and imx_v6_v7_defconfig targets, the following
build error is observed:
drivers/pinctrl/core.c:87:6: error: redefinition of 'pinctrl_provide_dummies'
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
This applies against linux-next-20120528
drivers/pinctrl/core.c | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 4446a33..4e89097 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -76,19 +76,6 @@ void pinctrl_provide_dummies(void)
pinctrl_dummy_state = true;
}
-/**
- * pinctrl_provide_dummies() - indicate if pinctrl provides dummy state support
- *
- * Usually this function is called by platforms without pinctrl driver support
- * but run with some shared drivers using pinctrl APIs.
- * After calling this function, the pinctrl core will return successfully
- * with creating a dummy state for the driver to keep going smoothly.
- */
-void pinctrl_provide_dummies(void)
-{
- pinctrl_dummy_state = true;
-}
-
const char *pinctrl_dev_get_name(struct pinctrl_dev *pctldev)
{
/* We're not allowed to register devices without name */
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] dummies
2012-05-29 3:13 [PATCH] dummies Fabio Estevam
@ 2012-06-05 12:47 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-06-05 12:47 UTC (permalink / raw)
To: Sascha Hauer, Shawn Guo; +Cc: linux-kernel, Fabio Estevam
On Tue, May 29, 2012 at 5:13 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> For mxs_defconfig and imx_v6_v7_defconfig targets, the following
> build error is observed:
>
> drivers/pinctrl/core.c:87:6: error: redefinition of 'pinctrl_provide_dummies'
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Shawn can you ACK/NACK this patch?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-05 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-29 3:13 [PATCH] dummies Fabio Estevam
2012-06-05 12:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®