[PATCH] drivers: pinctrl: Remove redefinition of 'pinctrl_provide_dummies'

[PATCH] drivers: pinctrl: Remove redefinition of 'pinctrl_provide_dummies'

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

For mxs_defconfig and imx_v6_v7_defconfig targets, the following
build error is observed:

drivers/pinctrl/core.c:87:6: error: redefinition of 'pinctrl_provide_dummies'

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
This applies against linux-next-20120528

 drivers/pinctrl/core.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 4446a33..4e89097 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -76,19 +76,6 @@ void pinctrl_provide_dummies(void)
 	pinctrl_dummy_state = true;
 }
 
-/**
- * pinctrl_provide_dummies() - indicate if pinctrl provides dummy state support
- *
- * Usually this function is called by platforms without pinctrl driver support
- * but run with some shared drivers using pinctrl APIs.
- * After calling this function, the pinctrl core will return successfully
- * with creating a dummy state for the driver to keep going smoothly.
- */
-void pinctrl_provide_dummies(void)
-{
-	pinctrl_dummy_state = true;
-}
-
 const char *pinctrl_dev_get_name(struct pinctrl_dev *pctldev)
 {
 	/* We're not allowed to register devices without name */
-- 
1.7.1

Re: [PATCH] drivers: pinctrl: Remove redefinition of 'pinctrl_provide_dummies'

[Linus Walleij]

On Tue, May 29, 2012 at 5:14 AM, Fabio Estevam <festevam@gmail.com> wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> For mxs_defconfig and imx_v6_v7_defconfig targets, the following
> build error is observed:
>
> drivers/pinctrl/core.c:87:6: error: redefinition of 'pinctrl_provide_dummies'
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Shawn, have a look at this too...

Fabio, please use subject:
pinctrl: mxs: foo

Yours,
Linus Walleij

Re: [PATCH] drivers: pinctrl: Remove redefinition of 'pinctrl_provide_dummies'

[Fabio Estevam]

Linus,

On Tue, Jun 5, 2012 at 9:48 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, May 29, 2012 at 5:14 AM, Fabio Estevam <festevam@gmail.com> wrote:
>
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> For mxs_defconfig and imx_v6_v7_defconfig targets, the following
>> build error is observed:
>>
>> drivers/pinctrl/core.c:87:6: error: redefinition of 'pinctrl_provide_dummies'
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Shawn, have a look at this too...
>
> Fabio, please use subject:
> pinctrl: mxs: foo

This error does not show up in linux-next anymore, so please discard this patch.

Regards,

Fabio Estevam