From: Chris Yungmann <yungmann.chris@gmail.com>
To: yungmann.chris@gmail.com, w.d.hubbs@gmail.com,
chris@the-brannons.com, kirk@braille.uwo.ca,
samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org
Cc: speakup@braille.uwo.ca, linux-kernel@vger.kernel.org,
kernelnewbies@kernelnewbies.org
Subject: [PATCH] staging: speakup: fixed checkpatch and sparse warnings in selection.c
Date: Sat, 2 Jun 2012 12:32:38 -0500 [thread overview]
Message-ID: <1338658358-20402-1-git-send-email-yungmann.chris@gmail.com> (raw)
Signed-off-by: Chris Yungmann <yungmann.chris@gmail.com>
---
drivers/staging/speakup/selection.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/speakup/selection.c b/drivers/staging/speakup/selection.c
index fe1f405..496c81e 100644
--- a/drivers/staging/speakup/selection.c
+++ b/drivers/staging/speakup/selection.c
@@ -68,7 +68,7 @@ int speakup_set_selection(struct tty_struct *tty)
if (spk_sel_cons != vc_cons[fg_console].d) {
speakup_clear_selection();
spk_sel_cons = vc_cons[fg_console].d;
- printk(KERN_WARNING
+ pr_warn(KERN_WARNING
"Selection: mark console not the same as cut\n");
return -EINVAL;
}
@@ -95,7 +95,7 @@ int speakup_set_selection(struct tty_struct *tty)
/* Allocate a new buffer before freeing the old one ... */
bp = kmalloc((sel_end-sel_start)/2+1, GFP_ATOMIC);
if (!bp) {
- printk(KERN_WARNING "selection: kmalloc() failed\n");
+ pr_warn(KERN_WARNING "selection: kmalloc() failed\n");
speakup_clear_selection();
return -ENOMEM;
}
@@ -132,7 +132,7 @@ int speakup_paste_selection(struct tty_struct *tty)
while (sel_buffer && sel_buffer_lth > pasted) {
set_current_state(TASK_INTERRUPTIBLE);
if (test_bit(TTY_THROTTLED, &tty->flags)) {
- if (in_atomic())
+ if (in_interrupt())
/* if we are in an interrupt handler, abort */
break;
schedule();
@@ -141,7 +141,7 @@ int speakup_paste_selection(struct tty_struct *tty)
count = sel_buffer_lth - pasted;
count = min_t(int, count, tty->receive_room);
tty->ldisc->ops->receive_buf(tty, sel_buffer + pasted,
- 0, count);
+ NULL, count);
pasted += count;
}
remove_wait_queue(&vc->paste_wait, &wait);
--
1.7.10
next reply other threads:[~2012-06-02 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 17:32 Chris Yungmann [this message]
2012-06-03 14:20 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338658358-20402-1-git-send-email-yungmann.chris@gmail.com \
--to=yungmann.chris@gmail.com \
--cc=chris@the-brannons.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=kirk@braille.uwo.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@braille.uwo.ca \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®