From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Chris Yungmann <yungmann.chris@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@braille.uwo.ca,
gregkh@linuxfoundation.org, speakup@braille.uwo.ca,
linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] staging: speakup: fixed checkpatch and sparse warnings in selection.c
Date: Sun, 3 Jun 2012 16:20:21 +0200 [thread overview]
Message-ID: <20120603142021.GI4546@type.famille.thibault.fr> (raw)
In-Reply-To: <1338658358-20402-1-git-send-email-yungmann.chris@gmail.com>
Chris Yungmann, le Sat 02 Jun 2012 12:32:38 -0500, a écrit :
> @@ -132,7 +132,7 @@ int speakup_paste_selection(struct tty_struct *tty)
> while (sel_buffer && sel_buffer_lth > pasted) {
> set_current_state(TASK_INTERRUPTIBLE);
> if (test_bit(TTY_THROTTLED, &tty->flags)) {
> - if (in_atomic())
> + if (in_interrupt())
> /* if we are in an interrupt handler, abort */
> break;
> schedule();
I'd rather keep in_atomic(), which is clearly known to be broken (see
TODO above).
Samuel
prev parent reply other threads:[~2012-06-03 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 17:32 Chris Yungmann
2012-06-03 14:20 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120603142021.GI4546@type.famille.thibault.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=kirk@braille.uwo.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@braille.uwo.ca \
--cc=w.d.hubbs@gmail.com \
--cc=yungmann.chris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®