* build failure in mm/nommu.c
@ 2012-06-04 14:09 Mark Salter
2012-06-04 23:50 ` David Rientjes
0 siblings, 1 reply; 2+ messages in thread
From: Mark Salter @ 2012-06-04 14:09 UTC (permalink / raw)
To: Alexander Viro; +Cc: linux-kernel
Commit eb36c587: new helper: vm_mmap_pgoff()
is causing a build failure:
.../linux/mm/nommu.c: In function 'sys_mmap_pgoff':
.../linux/mm/nommu.c:1489:2: error: 'ret' undeclared (first use in this function)
.../linux/mm/nommu.c:1489:2: note: each undeclared identifier is reported only once for each function it appears in
It looks like it just needs:
diff --git a/mm/nommu.c b/mm/nommu.c
index c4acfbc..d4b0c10 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -1486,7 +1486,7 @@ SYSCALL_DEFINE6(mmap_pgoff, unsigned long, addr, unsigned long, len,
flags &= ~(MAP_EXECUTABLE | MAP_DENYWRITE);
- ret = vm_mmap_pgoff(file, addr, len, prot, flags, pgoff);
+ retval = vm_mmap_pgoff(file, addr, len, prot, flags, pgoff);
if (file)
fput(file);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: build failure in mm/nommu.c
2012-06-04 14:09 build failure in mm/nommu.c Mark Salter
@ 2012-06-04 23:50 ` David Rientjes
0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes @ 2012-06-04 23:50 UTC (permalink / raw)
To: Mark Salter; +Cc: Alexander Viro, linux-kernel
On Mon, 4 Jun 2012, Mark Salter wrote:
> Commit eb36c587: new helper: vm_mmap_pgoff()
>
> is causing a build failure:
>
> .../linux/mm/nommu.c: In function 'sys_mmap_pgoff':
> .../linux/mm/nommu.c:1489:2: error: 'ret' undeclared (first use in this function)
> .../linux/mm/nommu.c:1489:2: note: each undeclared identifier is reported only once for each function it appears in
>
Try pulling from Linus again, this is fixed by ad1ed2937eaa ("nommu: fix
compilation of nommu.c") in his tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-04 23:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-04 14:09 build failure in mm/nommu.c Mark Salter
2012-06-04 23:50 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®