[next-net PATCH] drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX name output by e1000e

[next-net PATCH] drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX name output by e1000e

[Ethan Zhao]

commit ca3ccc6835943287b6f69e973c126a02bc4de409
Author: ethan.zhao <ethan.kernel@gmail.com>
Date:   Wed Jun 6 07:32:11 2012 -0700

        modified:   drivers/net/ethernet/intel/e1000e/param.c

    While e1000e_check_options() is called, netdev is not registered, so the
    e1000e driver will print out confused ethernet interface name
(unregistered net_device) :

    e1000e 0000:04:00.0:(unregistered net_device): Interrupt
Throttling Rate (ints/sec) set to dynamic conservative mode

    So change e_info() back to dev_printk() by simply redefine the
e_info macro used by
    e1000e_check_options() and e1000_validate_option

    after applied this patch, we got:

    e1000e 0000:04:00.0: Interrupt Throttling Rate (ints/sec) set to
dynamic conservative mode
    e1000e 0000:04:00.0: irq 95 for MSI/MSI-X

diff --git a/drivers/net/ethernet/intel/e1000e/param.c
b/drivers/net/ethernet/intel/e1000e/param.c
index 55cc156..0f4f9db 100644
--- a/drivers/net/ethernet/intel/e1000e/param.c
+++ b/drivers/net/ethernet/intel/e1000e/param.c
@@ -186,6 +186,17 @@ struct e1000_option {
        } arg;
 };

+
+/**
+ * For netdev is not registered here, will get (unregistered
net_device) such confused
+ * name, so change back to dev_printk() lazy redfine the e_info()
+ */
+#ifdef e_info
+#undef e_info
+#define e_info(format, arg...) \
+       dev_printk(KERN_INFO,&adapter->pdev->dev, format, ## arg)
+#endif
+
 static int __devinit e1000_validate_option(unsigned int *value,
                                           const struct e1000_option *opt,
                                           struct e1000_adapter *adapter)

Re: [E1000-devel] [next-net PATCH] drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX name output by e1000e

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On Wed, 2012-06-06 at 22:57 +0800, Ethan Zhao wrote:
> commit ca3ccc6835943287b6f69e973c126a02bc4de409
> Author: ethan.zhao <ethan.kernel@gmail.com>
> Date:   Wed Jun 6 07:32:11 2012 -0700
> 
>         modified:   drivers/net/ethernet/intel/e1000e/param.c
> 
>     While e1000e_check_options() is called, netdev is not registered,
> so the
>     e1000e driver will print out confused ethernet interface name
> (unregistered net_device) :
> 
>     e1000e 0000:04:00.0:(unregistered net_device): Interrupt
> Throttling Rate (ints/sec) set to dynamic conservative mode
> 
>     So change e_info() back to dev_printk() by simply redefine the
> e_info macro used by
>     e1000e_check_options() and e1000_validate_option
> 
>     after applied this patch, we got:
> 
>     e1000e 0000:04:00.0: Interrupt Throttling Rate (ints/sec) set to
> dynamic conservative mode
>     e1000e 0000:04:00.0: irq 95 for MSI/MSI-X 

NACK, I currently have a patch in my queue from Bruce Allan to resolve
this issue.  I should be pushing the patch upstream in a few days.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [E1000-devel] [next-net PATCH] drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX name output by e1000e

[Allan, Bruce W]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1761 bytes --]

> -----Original Message-----
> From: Jeff Kirsher [mailto:jeffrey.t.kirsher@intel.com]
> Sent: Wednesday, June 06, 2012 5:41 PM
> To: Ethan Zhao
> Cc: e1000-devel@lists.sourceforge.net; Linux NICS; LKML
> Subject: Re: [E1000-devel] [next-net PATCH]
> drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX
> name output by e1000e
> 
> On Wed, 2012-06-06 at 22:57 +0800, Ethan Zhao wrote:
> > commit ca3ccc6835943287b6f69e973c126a02bc4de409
> > Author: ethan.zhao <ethan.kernel@gmail.com>
> > Date:   Wed Jun 6 07:32:11 2012 -0700
> >
> >         modified:   drivers/net/ethernet/intel/e1000e/param.c
> >
> >     While e1000e_check_options() is called, netdev is not
> registered,
> > so the
> >     e1000e driver will print out confused ethernet interface name
> > (unregistered net_device) :
> >
> >     e1000e 0000:04:00.0:(unregistered net_device): Interrupt
> > Throttling Rate (ints/sec) set to dynamic conservative mode
> >
> >     So change e_info() back to dev_printk() by simply redefine the
> > e_info macro used by
> >     e1000e_check_options() and e1000_validate_option
> >
> >     after applied this patch, we got:
> >
> >     e1000e 0000:04:00.0: Interrupt Throttling Rate (ints/sec) set to
> > dynamic conservative mode
> >     e1000e 0000:04:00.0: irq 95 for MSI/MSI-X
> 
> NACK, I currently have a patch in my queue from Bruce Allan to resolve
> this issue.  I should be pushing the patch upstream in a few days.

For clarification, the problem with the NACK'ed patch is it is missing a
number of instances of the same issue that is meant to be addressed by the
patch.

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [E1000-devel] [next-net PATCH] drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX name output by e1000e

[Ethan Zhao]

Jeff,
  That is OK, I would like to have a test if could share Allan's patch
for this issue.

Thanks.
Ethan


On Fri, Jun 8, 2012 at 6:39 AM, Jeff Kirsher
<jeffrey.t.kirsher@intel.com> wrote:
> It appears you are not understanding what Bruce and I have said.
>
> I am not adding your patch to my queue because Bruce has already a patch
> submitted to my queue which resolves the problem you reported.  So there
> is no need for a different patch from you to resolve the issue because
> it has already been taken care of by Bruce's patch.
>
> So NACK, and there is no need to begin another patch for this issue.
>
> If you find a different problem or issue with one of our drivers, feel
> free to submit a patch.  I am always open to patches from the community,
> just in this particular case, Bruce already had a patch that resolves
> this issue (in a more complete way).
>
> On Thu, 2012-06-07 at 23:02 +0800, Ethan.kernel@gmail wrote:
>> Jeffrey,
>>
>>         So, Could you help to put this patch in your queue if it worth 2 cents for some Linux users ?
>>
>> Or a NACK for any reason let me know just throw it and begin another.
>>
>> Thanks,
>> Ethan
>>
>> 在 2012-6-7，22:33，"Allan, Bruce W" <bruce.w.allan@intel.com> 写道：
>>
>> > Yes, my patch is different from yours.
>> >
>> >> -----Original Message-----
>> >> From: Ethan Zhao [mailto:ethan.kernel@gmail.com]
>> >> Sent: Wednesday, June 06, 2012 6:24 PM
>> >> To: Allan, Bruce W
>> >> Subject: Re: [E1000-devel] [next-net PATCH]
>> >> drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX
>> >> name output by e1000e
>> >>
>> >> Allan, So they are different patch ?
>> >> jeffrey, right ?
>> >>
>> >> Ethan
>> >>
>> >> On Thu, Jun 7, 2012 at 8:56 AM, Allan, Bruce W
>> >> <bruce.w.allan@intel.com> wrote:
>> >>>> -----Original Message-----
>> >>>> From: Jeff Kirsher [mailto:jeffrey.t.kirsher@intel.com]
>> >>>> Sent: Wednesday, June 06, 2012 5:41 PM
>> >>>> To: Ethan Zhao
>> >>>> Cc: e1000-devel@lists.sourceforge.net; Linux NICS; LKML
>> >>>> Subject: Re: [E1000-devel] [next-net PATCH]
>> >>>> drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX
>> >>>> name output by e1000e
>> >>>>
>> >>>> On Wed, 2012-06-06 at 22:57 +0800, Ethan Zhao wrote:
>> >>>>> commit ca3ccc6835943287b6f69e973c126a02bc4de409
>> >>>>> Author: ethan.zhao <ethan.kernel@gmail.com>
>> >>>>> Date:   Wed Jun 6 07:32:11 2012 -0700
>> >>>>>
>> >>>>>         modified:   drivers/net/ethernet/intel/e1000e/param.c
>> >>>>>
>> >>>>>     While e1000e_check_options() is called, netdev is not
>> >>>> registered,
>> >>>>> so the
>> >>>>>     e1000e driver will print out confused ethernet interface name
>> >>>>> (unregistered net_device) :
>> >>>>>
>> >>>>>     e1000e 0000:04:00.0:(unregistered net_device): Interrupt
>> >>>>> Throttling Rate (ints/sec) set to dynamic conservative mode
>> >>>>>
>> >>>>>     So change e_info() back to dev_printk() by simply redefine
>> >> the
>> >>>>> e_info macro used by
>> >>>>>     e1000e_check_options() and e1000_validate_option
>> >>>>>
>> >>>>>     after applied this patch, we got:
>> >>>>>
>> >>>>>     e1000e 0000:04:00.0: Interrupt Throttling Rate (ints/sec) set
>> >> to
>> >>>>> dynamic conservative mode
>> >>>>>     e1000e 0000:04:00.0: irq 95 for MSI/MSI-X
>> >>>>
>> >>>> NACK, I currently have a patch in my queue from Bruce Allan to
>> >> resolve
>> >>>> this issue.  I should be pushing the patch upstream in a few days.
>> >>>
>> >>> For clarification, the problem with the NACK'ed patch is it is
>> >> missing a
>> >>> number of instances of the same issue that is meant to be addressed
>> >> by the
>> >>> patch.
>> >>>
>
>