* [PATCH] rtc: twl: add missing IRQF_ONESHOT
@ 2012-06-14 10:26 Felipe Balbi
2012-06-14 11:08 ` Shilimkar, Santosh
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2012-06-14 10:26 UTC (permalink / raw)
To: a.zummo; +Cc: Linux Kernel Mailing List, rtc-linux, Felipe Balbi
This patch gets rid of the following warning:
[ 2.825378] genirq: Threaded irq requested with \
handler=NULL and !ONESHOT for irq 363
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/rtc/rtc-twl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index 258abea..c5d06fe 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
}
ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING | IRQF_ONESHOT,
dev_name(&rtc->dev), rtc);
if (ret < 0) {
dev_err(&pdev->dev, "IRQ is not free.\n");
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: twl: add missing IRQF_ONESHOT
2012-06-14 10:26 [PATCH] rtc: twl: add missing IRQF_ONESHOT Felipe Balbi
@ 2012-06-14 11:08 ` Shilimkar, Santosh
2012-06-14 11:08 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Shilimkar, Santosh @ 2012-06-14 11:08 UTC (permalink / raw)
To: Felipe Balbi; +Cc: a.zummo, Linux Kernel Mailing List, rtc-linux
On Thu, Jun 14, 2012 at 3:56 PM, Felipe Balbi <balbi@ti.com> wrote:
> This patch gets rid of the following warning:
>
> [ 2.825378] genirq: Threaded irq requested with \
> handler=NULL and !ONESHOT for irq 363
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
Ming Lei has posted a similar fix earlier [1]
Regards
Santosh
http://lkml.indiana.edu/hypermail/linux/kernel/1205.2/00668.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: twl: add missing IRQF_ONESHOT
2012-06-14 11:08 ` Shilimkar, Santosh
@ 2012-06-14 11:08 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2012-06-14 11:08 UTC (permalink / raw)
To: Shilimkar, Santosh
Cc: Felipe Balbi, a.zummo, Linux Kernel Mailing List, rtc-linux
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
Hi,
On Thu, Jun 14, 2012 at 04:38:34PM +0530, Shilimkar, Santosh wrote:
> On Thu, Jun 14, 2012 at 3:56 PM, Felipe Balbi <balbi@ti.com> wrote:
> > This patch gets rid of the following warning:
> >
> > [ 2.825378] genirq: Threaded irq requested with \
> > handler=NULL and !ONESHOT for irq 363
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
>
> Ming Lei has posted a similar fix earlier [1]
good, never mind this one then
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-14 11:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-14 10:26 [PATCH] rtc: twl: add missing IRQF_ONESHOT Felipe Balbi
2012-06-14 11:08 ` Shilimkar, Santosh
2012-06-14 11:08 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®