* [PATCH 1/2] w1: Fix a typo in 'hardware' word
@ 2012-06-17 3:06 Otavio Salvador
2012-06-17 3:06 ` [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free() Otavio Salvador
0 siblings, 1 reply; 5+ messages in thread
From: Otavio Salvador @ 2012-06-17 3:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Otavio Salvador, Evgeniy Polyakov
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
---
drivers/w1/w1_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c
index 6828835..afa5f5d 100644
--- a/drivers/w1/w1_int.c
+++ b/drivers/w1/w1_int.c
@@ -117,7 +117,7 @@ int w1_add_master_device(struct w1_bus_master *master)
return(-EINVAL);
}
/* While it would be electrically possible to make a device that
- * generated a strong pullup in bit bang mode, only hardare that
+ * generated a strong pullup in bit bang mode, only hardware that
* controls 1-wire time frames are even expected to support a strong
* pullup. w1_io.c would need to support calling set_pullup before
* the last write_bit operation of a w1_write_8 which it currently
--
1.7.10
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free()
2012-06-17 3:06 [PATCH 1/2] w1: Fix a typo in 'hardware' word Otavio Salvador
@ 2012-06-17 3:06 ` Otavio Salvador
0 siblings, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2012-06-17 3:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Otavio Salvador, Linus Walleij
,--[ build failure ]
| ...
| .../pinctrl-mxs.c: In function 'mxs_dt_node_to_map':
| .../pinctrl-mxs.c:140:3: error: implicit declaration of function 'free'
| [-Werror=implicit-function-declaration]
| .../pinctrl-mxs.c:140:3: warning: incompatible implicit declaration of
| built-in function 'free' [enabled by default]
| ...
`--
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/pinctrl-mxs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
index afb50ee..85f8dda 100644
--- a/drivers/pinctrl/pinctrl-mxs.c
+++ b/drivers/pinctrl/pinctrl-mxs.c
@@ -136,8 +136,7 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev,
return 0;
free_group:
- if (!purecfg)
- free(group);
+ kfree(group);
free:
kfree(new_map);
return ret;
--
1.7.10
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] w1: Fix a typo in 'hardware' word
@ 2012-06-17 15:17 Otavio Salvador
2012-06-17 22:01 ` Evgeniy Polyakov
0 siblings, 1 reply; 5+ messages in thread
From: Otavio Salvador @ 2012-06-17 15:17 UTC (permalink / raw)
To: linux-kernel; +Cc: Otavio Salvador, Evgeniy Polyakov
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
---
drivers/w1/w1_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c
index 6828835..afa5f5d 100644
--- a/drivers/w1/w1_int.c
+++ b/drivers/w1/w1_int.c
@@ -117,7 +117,7 @@ int w1_add_master_device(struct w1_bus_master *master)
return(-EINVAL);
}
/* While it would be electrically possible to make a device that
- * generated a strong pullup in bit bang mode, only hardare that
+ * generated a strong pullup in bit bang mode, only hardware that
* controls 1-wire time frames are even expected to support a strong
* pullup. w1_io.c would need to support calling set_pullup before
* the last write_bit operation of a w1_write_8 which it currently
--
1.7.10
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] w1: Fix a typo in 'hardware' word
2012-06-17 15:17 [PATCH 1/2] w1: Fix a typo in 'hardware' word Otavio Salvador
@ 2012-06-17 22:01 ` Evgeniy Polyakov
2012-06-17 23:49 ` GregKH
0 siblings, 1 reply; 5+ messages in thread
From: Evgeniy Polyakov @ 2012-06-17 22:01 UTC (permalink / raw)
To: Otavio Salvador; +Cc: linux-kernel, GregKH
On Sun, Jun 17, 2012 at 12:17:31PM -0300, Otavio Salvador (otavio@ossystems.com.br) wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Cc: Evgeniy Polyakov <zbr@ioremap.net>
Looks good, acked-by Evgeniy Polyakov <zbr@ioremap.net>
Greg, please pull it into your tree or suggest janitorial contact
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] w1: Fix a typo in 'hardware' word
2012-06-17 22:01 ` Evgeniy Polyakov
@ 2012-06-17 23:49 ` GregKH
0 siblings, 0 replies; 5+ messages in thread
From: GregKH @ 2012-06-17 23:49 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: Otavio Salvador, linux-kernel
On Mon, Jun 18, 2012 at 02:01:28AM +0400, Evgeniy Polyakov wrote:
> On Sun, Jun 17, 2012 at 12:17:31PM -0300, Otavio Salvador (otavio@ossystems.com.br) wrote:
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > Cc: Evgeniy Polyakov <zbr@ioremap.net>
>
> Looks good, acked-by Evgeniy Polyakov <zbr@ioremap.net>
> Greg, please pull it into your tree or suggest janitorial contact
I'll take it, but for "trivial" patches, there is always the trivial
kernel maintainer, which is good for spelling fixes and other stuff like
that.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-17 23:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-17 3:06 [PATCH 1/2] w1: Fix a typo in 'hardware' word Otavio Salvador
2012-06-17 3:06 ` [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free() Otavio Salvador
2012-06-17 15:17 [PATCH 1/2] w1: Fix a typo in 'hardware' word Otavio Salvador
2012-06-17 22:01 ` Evgeniy Polyakov
2012-06-17 23:49 ` GregKH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®