[PATCH] parisc: fix the exit status of arch/parisc/nm

[PATCH] parisc: fix the exit status of arch/parisc/nm

[Masahiro Yamada]

Parisc overrides 'nm' with a shell script. I was hit by a false-positive
error of $(NM) because this script returns the exit code of grep instead
of ${CROSS_COMPILE}nm. (grep exits with 1 if no lines were selected)

I tried to fix it, but in the code review, Helge suggested to remove it
entirely. [1]

This script was added in 2003. [2]

Presumably, it was a workaround for old toolchains (but even the parisc
maintainer does not know the detail any more).

Hopefully recent tools should work fine.

[1]: https://lore.kernel.org/all/1c12cd26-d8aa-4498-f4c0-29478b9578fe@gmx.de/
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=36eaa6e4c0e0b6950136b956b72fd08155b92ca3

Suggested-by: Helge Deller <deller@gmx.de>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

I want to apply this to kbuild tree with Helge's Ack

 arch/parisc/Makefile | 1 -
 arch/parisc/nm       | 6 ------
 2 files changed, 7 deletions(-)
 delete mode 100644 arch/parisc/nm

diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index aca1710fd658..e38d993d87f2 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -18,7 +18,6 @@
 boot := arch/parisc/boot
 KBUILD_IMAGE := $(boot)/bzImage
 
-NM		= sh $(srctree)/arch/parisc/nm
 CHECKFLAGS	+= -D__hppa__=1
 
 ifdef CONFIG_64BIT
diff --git a/arch/parisc/nm b/arch/parisc/nm
deleted file mode 100644
index c788308de33f..000000000000
--- a/arch/parisc/nm
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/sh
-##
-# Hack to have an nm which removes the local symbols.  We also rely
-# on this nm being hidden out of the ordinarily executable path
-##
-${CROSS_COMPILE}nm $* | grep -v '.LC*[0-9]*$'
-- 
2.32.0

Re: [PATCH] parisc: fix the exit status of arch/parisc/nm

[Helge Deller]

On 5/27/22 16:39, Masahiro Yamada wrote:
> Parisc overrides 'nm' with a shell script. I was hit by a false-positive
> error of $(NM) because this script returns the exit code of grep instead
> of ${CROSS_COMPILE}nm. (grep exits with 1 if no lines were selected)
>
> I tried to fix it, but in the code review, Helge suggested to remove it
> entirely. [1]
>
> This script was added in 2003. [2]
>
> Presumably, it was a workaround for old toolchains (but even the parisc
> maintainer does not know the detail any more).
>
> Hopefully recent tools should work fine.
>
> [1]: https://lore.kernel.org/all/1c12cd26-d8aa-4498-f4c0-29478b9578fe@gmx.de/
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=36eaa6e4c0e0b6950136b956b72fd08155b92ca3
>
> Suggested-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Acked-by: Helge Deller <deller@gmx.de>

Thank you!
Helge

> ---
>
> I want to apply this to kbuild tree with Helge's Ack
>
>  arch/parisc/Makefile | 1 -
>  arch/parisc/nm       | 6 ------
>  2 files changed, 7 deletions(-)
>  delete mode 100644 arch/parisc/nm
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index aca1710fd658..e38d993d87f2 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -18,7 +18,6 @@
>  boot := arch/parisc/boot
>  KBUILD_IMAGE := $(boot)/bzImage
>
> -NM		= sh $(srctree)/arch/parisc/nm
>  CHECKFLAGS	+= -D__hppa__=1
>
>  ifdef CONFIG_64BIT
> diff --git a/arch/parisc/nm b/arch/parisc/nm
> deleted file mode 100644
> index c788308de33f..000000000000
> --- a/arch/parisc/nm
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -#!/bin/sh
> -##
> -# Hack to have an nm which removes the local symbols.  We also rely
> -# on this nm being hidden out of the ordinarily executable path
> -##
> -${CROSS_COMPILE}nm $* | grep -v '.LC*[0-9]*$'

Re: [PATCH] parisc: fix the exit status of arch/parisc/nm

[Masahiro Yamada]

On Sat, May 28, 2022 at 12:32 AM Helge Deller <deller@gmx.de> wrote:
>
> On 5/27/22 16:39, Masahiro Yamada wrote:
> > Parisc overrides 'nm' with a shell script. I was hit by a false-positive
> > error of $(NM) because this script returns the exit code of grep instead
> > of ${CROSS_COMPILE}nm. (grep exits with 1 if no lines were selected)
> >
> > I tried to fix it, but in the code review, Helge suggested to remove it
> > entirely. [1]
> >
> > This script was added in 2003. [2]
> >
> > Presumably, it was a workaround for old toolchains (but even the parisc
> > maintainer does not know the detail any more).
> >
> > Hopefully recent tools should work fine.
> >
> > [1]: https://lore.kernel.org/all/1c12cd26-d8aa-4498-f4c0-29478b9578fe@gmx.de/
> > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=36eaa6e4c0e0b6950136b956b72fd08155b92ca3
> >
> > Suggested-by: Helge Deller <deller@gmx.de>
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Acked-by: Helge Deller <deller@gmx.de>
>
> Thank you!
> Helge
>


I just forgot to change the patch subject.

I changed it to

"parisc: remove arch/parisc/nm"

Applied to linux-kbuild.
Thanks for the ack.



-- 
Best Regards
Masahiro Yamada