From: Joe Perches <joe@perches.com>
To: Henry Sloan <henryksloan@gmail.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] KVM: Replace bare 'unsigned' with 'unsigned int'
Date: Sat, 05 Mar 2022 17:53:24 -0800 [thread overview]
Message-ID: <133c543af026f99f0cd148d4403cf426e8470666.camel@perches.com> (raw)
In-Reply-To: <CAFJXJGHc3D3U+BOBW2BqSX-vhsXSCZ-=R2ydfMtVML02+C3MuQ@mail.gmail.com>
On Sat, 2022-03-05 at 20:44 -0500, Henry Sloan wrote:
> I agree the bool conversion should be a separate patch. Would it be proper
> to resubmit the whole patchset with a new, seventh patch containing the
> bool conversion? If I was to do so, should all of those patches be labelled
> v2, but without any changelogs since none of the present patches will have
> been changed?
Generally yes, but it depends on the upstream maintainer's preference.
Ideally:
o a 0/n patch cover letter could be used to describe the change/addition
o each proposed patch has a patch description above your Signed-off-by:
prev parent reply other threads:[~2022-03-06 1:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 20:55 [PATCH 0/6] KVM: fix checkpatch warnings Henry Sloan
2022-03-05 20:55 ` [PATCH 1/6] KVM: Use typical SPDX comment style Henry Sloan
2022-03-05 20:55 ` [PATCH 2/6] KVM: Replace bare 'unsigned' with 'unsigned int' Henry Sloan
2022-03-06 0:49 ` Joe Perches
2022-03-05 20:55 ` [PATCH 3/6] KVM: Replace '__attribute__((weak))' with '__weak' Henry Sloan
2022-03-05 20:55 ` [PATCH 4/6] KVM: Add blank lines after some declarations Henry Sloan
2022-03-05 20:55 ` [PATCH 5/6] KVM: Use typical style for block comments Henry Sloan
2022-03-05 20:55 ` [PATCH 6/6] KVM: Fix minor indentation and brace style issues Henry Sloan
2022-03-05 21:07 ` Joe Perches
2022-03-05 21:53 ` [PATCH v2 " Henry Sloan
2022-03-06 1:28 ` [PATCH v2 2/6] KVM: Replace bare 'unsigned' with 'unsigned int' Henry Sloan
2022-03-06 1:37 ` Joe Perches
[not found] ` <CAFJXJGHc3D3U+BOBW2BqSX-vhsXSCZ-=R2ydfMtVML02+C3MuQ@mail.gmail.com>
2022-03-06 1:53 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=133c543af026f99f0cd148d4403cf426e8470666.camel@perches.com \
--to=joe@perches.com \
--cc=henryksloan@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®