From: Jiri Olsa <jolsa@redhat.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
fweisbec@gmail.com
Cc: eranian@google.com, gorcunov@openvz.org, tzanussi@gmail.com,
mhiramat@redhat.com, robert.richter@amd.com, fche@redhat.com,
linux-kernel@vger.kernel.org, masami.hiramatsu.pt@hitachi.com,
drepper@gmail.com, asharma@fb.com,
benjamin.redelings@nescent.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 11/23] perf, tool: Remove unsused evsel parameter from machine__resolve_callchain
Date: Tue, 19 Jun 2012 17:48:02 +0200 [thread overview]
Message-ID: <1340120894-9465-12-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1340120894-9465-1-git-send-email-jolsa@redhat.com>
Removing unsused evsel parameter from machine__resolve_callchain
function. Plus related header file and callers changes.
The evsel parameter is unused since following commit:
perf callchain: Make callchain cursors TLS
commit 472606458f3e1ced5fe3cc5f04e90a6b5a4732cf
Author: Namhyung Kim <namhyung.kim@lge.com>
Date: Thu May 31 14:43:26 2012 +0900
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/builtin-report.c | 4 ++--
tools/perf/builtin-script.c | 4 ++--
tools/perf/builtin-top.c | 2 +-
tools/perf/util/map.h | 2 +-
tools/perf/util/session.c | 7 +++----
tools/perf/util/session.h | 4 ++--
6 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 25249f7..d20ef95 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -69,7 +69,7 @@ static int perf_report__add_branch_hist_entry(struct perf_tool *tool,
if ((sort__has_parent || symbol_conf.use_callchain)
&& sample->callchain) {
- err = machine__resolve_callchain(machine, evsel, al->thread,
+ err = machine__resolve_callchain(machine, al->thread,
sample->callchain, &parent);
if (err)
return err;
@@ -140,7 +140,7 @@ static int perf_evsel__add_hist_entry(struct perf_evsel *evsel,
struct hist_entry *he;
if ((sort__has_parent || symbol_conf.use_callchain) && sample->callchain) {
- err = machine__resolve_callchain(machine, evsel, al->thread,
+ err = machine__resolve_callchain(machine, al->thread,
sample->callchain, &parent);
if (err)
return err;
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 8e395a5..05aa2bb 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -387,7 +387,7 @@ static void print_sample_bts(union perf_event *event,
printf(" ");
else
printf("\n");
- perf_event__print_ip(event, sample, machine, evsel,
+ perf_event__print_ip(event, sample, machine,
PRINT_FIELD(SYM), PRINT_FIELD(DSO),
PRINT_FIELD(SYMOFFSET));
}
@@ -431,7 +431,7 @@ static void process_event(union perf_event *event __unused,
printf(" ");
else
printf("\n");
- perf_event__print_ip(event, sample, machine, evsel,
+ perf_event__print_ip(event, sample, machine,
PRINT_FIELD(SYM), PRINT_FIELD(DSO),
PRINT_FIELD(SYMOFFSET));
}
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 6bb0277..79cabe4 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -774,7 +774,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
if ((sort__has_parent || symbol_conf.use_callchain) &&
sample->callchain) {
- err = machine__resolve_callchain(machine, evsel, al.thread,
+ err = machine__resolve_callchain(machine, al.thread,
sample->callchain, &parent);
if (err)
return;
diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h
index 81371ba..c14c665 100644
--- a/tools/perf/util/map.h
+++ b/tools/perf/util/map.h
@@ -157,7 +157,7 @@ void machine__exit(struct machine *self);
void machine__delete(struct machine *self);
int machine__resolve_callchain(struct machine *machine,
- struct perf_evsel *evsel, struct thread *thread,
+ struct thread *thread,
struct ip_callchain *chain,
struct symbol **parent);
int maps__set_kallsyms_ref_reloc_sym(struct map **maps, const char *symbol_name,
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index c3e399b..eb2f900 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -289,7 +289,6 @@ struct branch_info *machine__resolve_bstack(struct machine *self,
}
int machine__resolve_callchain(struct machine *self,
- struct perf_evsel *evsel __used,
struct thread *thread,
struct ip_callchain *chain,
struct symbol **parent)
@@ -1490,8 +1489,8 @@ struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session,
}
void perf_event__print_ip(union perf_event *event, struct perf_sample *sample,
- struct machine *machine, struct perf_evsel *evsel,
- int print_sym, int print_dso, int print_symoffset)
+ struct machine *machine, int print_sym,
+ int print_dso, int print_symoffset)
{
struct addr_location al;
struct callchain_cursor_node *node;
@@ -1505,7 +1504,7 @@ void perf_event__print_ip(union perf_event *event, struct perf_sample *sample,
if (symbol_conf.use_callchain && sample->callchain) {
- if (machine__resolve_callchain(machine, evsel, al.thread,
+ if (machine__resolve_callchain(machine, al.thread,
sample->callchain, NULL) != 0) {
if (verbose)
error("Failed to resolve callchain. Skipping\n");
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
index 0c702e3..c71a1a7 100644
--- a/tools/perf/util/session.h
+++ b/tools/perf/util/session.h
@@ -151,8 +151,8 @@ struct perf_evsel *perf_session__find_first_evtype(struct perf_session *session,
unsigned int type);
void perf_event__print_ip(union perf_event *event, struct perf_sample *sample,
- struct machine *machine, struct perf_evsel *evsel,
- int print_sym, int print_dso, int print_symoffset);
+ struct machine *machine, int print_sym,
+ int print_dso, int print_symoffset);
int perf_session__cpu_bitmap(struct perf_session *session,
const char *cpu_list, unsigned long *cpu_bitmap);
--
1.7.7.6
next prev parent reply other threads:[~2012-06-19 15:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 15:47 [RFCv5 00/23] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-06-19 15:47 ` [PATCH 01/23] tracing/filter: Add missing initialization Jiri Olsa
2012-08-21 15:17 ` [tip:perf/core] " tip-bot for Jiri Olsa
2012-06-19 15:47 ` [PATCH 02/23] perf: Unified API to record selective sets of arch registers Jiri Olsa
2012-06-20 16:42 ` Frederic Weisbecker
2012-06-20 17:39 ` Jiri Olsa
2012-06-27 14:58 ` Frederic Weisbecker
2012-06-29 7:36 ` Jiri Olsa
2012-06-19 15:47 ` [PATCH 03/23] perf: Add ability to attach user level registers dump to sample Jiri Olsa
2012-06-27 15:11 ` Frederic Weisbecker
2012-06-27 15:13 ` Stephane Eranian
2012-06-27 15:24 ` Frederic Weisbecker
2012-06-27 15:25 ` Peter Zijlstra
2012-06-27 15:30 ` Frederic Weisbecker
2012-06-29 7:50 ` Jiri Olsa
2012-06-29 11:23 ` Frederic Weisbecker
2012-06-29 11:30 ` Jiri Olsa
2012-06-29 11:39 ` Frederic Weisbecker
2012-06-19 15:47 ` [PATCH 04/23] perf, x86: Add copy_from_user_nmi_nochk for best effort copy Jiri Olsa
2012-06-27 15:19 ` Frederic Weisbecker
2012-06-29 7:38 ` Jiri Olsa
2012-06-19 15:47 ` [PATCH 05/23] perf: Factor __output_copy to be usable with specific copy function Jiri Olsa
2012-06-19 15:47 ` [PATCH 06/23] perf: Add perf_output_skip function to skip bytes in sample Jiri Olsa
2012-06-27 15:32 ` Frederic Weisbecker
2012-06-19 15:47 ` [PATCH 07/23] perf: Add ability to attach user stack dump to sample Jiri Olsa
2012-06-19 15:47 ` [PATCH 08/23] perf: Add attribute to filter out callchains Jiri Olsa
2012-06-19 15:48 ` [RFC 09/23] x86_64: Store userspace rsp in system_call fastpath Jiri Olsa
2012-06-28 12:08 ` Frederic Weisbecker
2012-06-29 8:03 ` Jiri Olsa
2012-06-29 11:37 ` Frederic Weisbecker
2012-06-19 15:48 ` [PATCH 10/23] perf, tool: Adding PERF_ATTR_SIZE_VER2 to the header swap check Jiri Olsa
2012-06-19 15:48 ` Jiri Olsa [this message]
2012-06-19 15:48 ` [PATCH 12/23] perf, tool: Factor DSO symtab types to generic binary types Jiri Olsa
2012-06-19 15:48 ` [PATCH 13/23] perf, tool: Add interface to read DSO image data Jiri Olsa
2012-06-19 15:48 ` [PATCH 14/23] perf, tool: Add '.note' check into search for NOTE section Jiri Olsa
2012-07-06 10:59 ` [tip:perf/core] perf symbols: " tip-bot for Jiri Olsa
2012-06-19 15:48 ` [PATCH 15/23] perf, tool: Back [vdso] DSO with real data Jiri Olsa
2012-06-19 15:48 ` [PATCH 16/23] perf, tool: Add interface to arch registers sets Jiri Olsa
2012-06-19 15:48 ` [PATCH 17/23] perf, tool: Add libunwind dependency for dwarf cfi unwinding Jiri Olsa
2012-06-19 15:48 ` [PATCH 18/23] perf, tool: Support user regs and stack in sample parsing Jiri Olsa
2012-06-19 15:48 ` [PATCH 19/23] perf, tool: Support for dwarf cfi unwinding on post processing Jiri Olsa
2012-06-19 15:48 ` [PATCH 20/23] perf, tool: Adding round_up/round_down macros Jiri Olsa
2012-07-06 11:00 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-06-19 15:48 ` [PATCH 21/23] perf, tool: Support for dwarf mode callchain on perf record Jiri Olsa
2012-06-19 15:48 ` [PATCH 22/23] perf, tool: Add dso data caching Jiri Olsa
2012-06-19 15:48 ` [PATCH 23/23] perf, tool: Add dso data caching tests Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340120894-9465-12-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=asharma@fb.com \
--cc=benjamin.redelings@nescent.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=drepper@gmail.com \
--cc=eranian@google.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®