From: Jiri Olsa <jolsa@redhat.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
fweisbec@gmail.com
Cc: eranian@google.com, gorcunov@openvz.org, tzanussi@gmail.com,
mhiramat@redhat.com, robert.richter@amd.com, fche@redhat.com,
linux-kernel@vger.kernel.org, masami.hiramatsu.pt@hitachi.com,
drepper@gmail.com, asharma@fb.com,
benjamin.redelings@nescent.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 14/23] perf, tool: Add '.note' check into search for NOTE section
Date: Tue, 19 Jun 2012 17:48:05 +0200 [thread overview]
Message-ID: <1340120894-9465-15-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1340120894-9465-1-git-send-email-jolsa@redhat.com>
Adding '.note' section name to be check when looking for notes
section. The '.note' name is used by kernel VDSO.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/util/symbol.c | 29 +++++++++++++++++++++++------
1 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 425bea5..59012fc 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1503,14 +1503,31 @@ static int elf_read_build_id(Elf *elf, void *bf, size_t size)
goto out;
}
- sec = elf_section_by_name(elf, &ehdr, &shdr,
- ".note.gnu.build-id", NULL);
- if (sec == NULL) {
+ /*
+ * Check following sections for notes:
+ * '.note.gnu.build-id'
+ * '.notes'
+ * '.note' (VDSO specific)
+ */
+ do {
+ sec = elf_section_by_name(elf, &ehdr, &shdr,
+ ".note.gnu.build-id", NULL);
+ if (sec)
+ break;
+
sec = elf_section_by_name(elf, &ehdr, &shdr,
".notes", NULL);
- if (sec == NULL)
- goto out;
- }
+ if (sec)
+ break;
+
+ sec = elf_section_by_name(elf, &ehdr, &shdr,
+ ".note", NULL);
+ if (sec)
+ break;
+
+ return err;
+
+ } while (0);
data = elf_getdata(sec, NULL);
if (data == NULL)
--
1.7.7.6
next prev parent reply other threads:[~2012-06-19 15:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 15:47 [RFCv5 00/23] perf: Add backtrace post dwarf unwind Jiri Olsa
2012-06-19 15:47 ` [PATCH 01/23] tracing/filter: Add missing initialization Jiri Olsa
2012-08-21 15:17 ` [tip:perf/core] " tip-bot for Jiri Olsa
2012-06-19 15:47 ` [PATCH 02/23] perf: Unified API to record selective sets of arch registers Jiri Olsa
2012-06-20 16:42 ` Frederic Weisbecker
2012-06-20 17:39 ` Jiri Olsa
2012-06-27 14:58 ` Frederic Weisbecker
2012-06-29 7:36 ` Jiri Olsa
2012-06-19 15:47 ` [PATCH 03/23] perf: Add ability to attach user level registers dump to sample Jiri Olsa
2012-06-27 15:11 ` Frederic Weisbecker
2012-06-27 15:13 ` Stephane Eranian
2012-06-27 15:24 ` Frederic Weisbecker
2012-06-27 15:25 ` Peter Zijlstra
2012-06-27 15:30 ` Frederic Weisbecker
2012-06-29 7:50 ` Jiri Olsa
2012-06-29 11:23 ` Frederic Weisbecker
2012-06-29 11:30 ` Jiri Olsa
2012-06-29 11:39 ` Frederic Weisbecker
2012-06-19 15:47 ` [PATCH 04/23] perf, x86: Add copy_from_user_nmi_nochk for best effort copy Jiri Olsa
2012-06-27 15:19 ` Frederic Weisbecker
2012-06-29 7:38 ` Jiri Olsa
2012-06-19 15:47 ` [PATCH 05/23] perf: Factor __output_copy to be usable with specific copy function Jiri Olsa
2012-06-19 15:47 ` [PATCH 06/23] perf: Add perf_output_skip function to skip bytes in sample Jiri Olsa
2012-06-27 15:32 ` Frederic Weisbecker
2012-06-19 15:47 ` [PATCH 07/23] perf: Add ability to attach user stack dump to sample Jiri Olsa
2012-06-19 15:47 ` [PATCH 08/23] perf: Add attribute to filter out callchains Jiri Olsa
2012-06-19 15:48 ` [RFC 09/23] x86_64: Store userspace rsp in system_call fastpath Jiri Olsa
2012-06-28 12:08 ` Frederic Weisbecker
2012-06-29 8:03 ` Jiri Olsa
2012-06-29 11:37 ` Frederic Weisbecker
2012-06-19 15:48 ` [PATCH 10/23] perf, tool: Adding PERF_ATTR_SIZE_VER2 to the header swap check Jiri Olsa
2012-06-19 15:48 ` [PATCH 11/23] perf, tool: Remove unsused evsel parameter from machine__resolve_callchain Jiri Olsa
2012-06-19 15:48 ` [PATCH 12/23] perf, tool: Factor DSO symtab types to generic binary types Jiri Olsa
2012-06-19 15:48 ` [PATCH 13/23] perf, tool: Add interface to read DSO image data Jiri Olsa
2012-06-19 15:48 ` Jiri Olsa [this message]
2012-07-06 10:59 ` [tip:perf/core] perf symbols: Add '.note' check into search for NOTE section tip-bot for Jiri Olsa
2012-06-19 15:48 ` [PATCH 15/23] perf, tool: Back [vdso] DSO with real data Jiri Olsa
2012-06-19 15:48 ` [PATCH 16/23] perf, tool: Add interface to arch registers sets Jiri Olsa
2012-06-19 15:48 ` [PATCH 17/23] perf, tool: Add libunwind dependency for dwarf cfi unwinding Jiri Olsa
2012-06-19 15:48 ` [PATCH 18/23] perf, tool: Support user regs and stack in sample parsing Jiri Olsa
2012-06-19 15:48 ` [PATCH 19/23] perf, tool: Support for dwarf cfi unwinding on post processing Jiri Olsa
2012-06-19 15:48 ` [PATCH 20/23] perf, tool: Adding round_up/round_down macros Jiri Olsa
2012-07-06 11:00 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-06-19 15:48 ` [PATCH 21/23] perf, tool: Support for dwarf mode callchain on perf record Jiri Olsa
2012-06-19 15:48 ` [PATCH 22/23] perf, tool: Add dso data caching Jiri Olsa
2012-06-19 15:48 ` [PATCH 23/23] perf, tool: Add dso data caching tests Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340120894-9465-15-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=asharma@fb.com \
--cc=benjamin.redelings@nescent.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=drepper@gmail.com \
--cc=eranian@google.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®