mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] allow padlock module to load without xcrypt support
@ 2012-06-20  9:22 Laszlo Ersek
  0 siblings, 0 replies; only message in thread
From: Laszlo Ersek @ 2012-06-20  9:22 UTC (permalink / raw)
  To: linux-kernel, lersek

Lack of (enabled) hardware is arguably not a module initialization error,
thus it should not cause problems during the boot process.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Please CC me on any comments. Thanks.

 drivers/crypto/padlock-aes.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/padlock-aes.c b/drivers/crypto/padlock-aes.c
index 37b2e94..a42a308 100644
--- a/drivers/crypto/padlock-aes.c
+++ b/drivers/crypto/padlock-aes.c
@@ -516,11 +516,11 @@ static int __init padlock_init(void)
 	struct cpuinfo_x86 *c = &cpu_data(0);
 
 	if (!x86_match_cpu(padlock_cpu_id))
-		return -ENODEV;
+		return 0;
 
 	if (!cpu_has_xcrypt_enabled) {
 		printk(KERN_NOTICE PFX "VIA PadLock detected, but not enabled. Hmm, strange...\n");
-		return -ENODEV;
+		return 0;
 	}
 
 	if ((ret = crypto_register_alg(&aes_alg)))
@@ -554,6 +554,9 @@ aes_err:
 
 static void __exit padlock_fini(void)
 {
+	if (!x86_match_cpu(padlock_cpu_id) || !cpu_has_xcrypt_enabled)
+		return;
+
 	crypto_unregister_alg(&cbc_aes_alg);
 	crypto_unregister_alg(&ecb_aes_alg);
 	crypto_unregister_alg(&aes_alg);
-- 
1.7.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-06-20  9:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-20  9:22 [PATCH] allow padlock module to load without xcrypt support Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®