mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] sparc: Correct comments about prom_init() return values
@ 2012-06-20 16:58 Geert Uytterhoeven
  2012-06-20 16:58 ` [PATCH 2/2] sparc32: Remove superfluous extern declarations for prom_*() functions Geert Uytterhoeven
  2012-06-27  8:34 ` [PATCH 1/2] sparc: Correct comments about prom_init() return values David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2012-06-20 16:58 UTC (permalink / raw)
  To: David S. Miller; +Cc: sparclinux, linux-kernel, Geert Uytterhoeven

prom_init() returns void.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/sparc/prom/init_32.c |    4 ++--
 arch/sparc/prom/init_64.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/sparc/prom/init_32.c b/arch/sparc/prom/init_32.c
index 26c64ce..a8d9342 100644
--- a/arch/sparc/prom/init_32.c
+++ b/arch/sparc/prom/init_32.c
@@ -27,8 +27,8 @@ EXPORT_SYMBOL(prom_root_node);
 struct linux_nodeops *prom_nodeops;
 
 /* You must call prom_init() before you attempt to use any of the
- * routines in the prom library.  It returns 0 on success, 1 on
- * failure.  It gets passed the pointer to the PROM vector.
+ * routines in the prom library.
+ * It gets passed the pointer to the PROM vector.
  */
 
 extern void prom_meminit(void);
diff --git a/arch/sparc/prom/init_64.c b/arch/sparc/prom/init_64.c
index 5016c5e..d95db75 100644
--- a/arch/sparc/prom/init_64.c
+++ b/arch/sparc/prom/init_64.c
@@ -22,8 +22,8 @@ int prom_stdout;
 phandle prom_chosen_node;
 
 /* You must call prom_init() before you attempt to use any of the
- * routines in the prom library.  It returns 0 on success, 1 on
- * failure.  It gets passed the pointer to the PROM vector.
+ * routines in the prom library.
+ * It gets passed the pointer to the PROM vector.
  */
 
 extern void prom_cif_init(void *, void *);
-- 
1.7.0.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] sparc32: Remove superfluous extern declarations for prom_*() functions
  2012-06-20 16:58 [PATCH 1/2] sparc: Correct comments about prom_init() return values Geert Uytterhoeven
@ 2012-06-20 16:58 ` Geert Uytterhoeven
  2012-06-27  8:35   ` David Miller
  2012-06-27  8:34 ` [PATCH 1/2] sparc: Correct comments about prom_init() return values David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2012-06-20 16:58 UTC (permalink / raw)
  To: David S. Miller; +Cc: sparclinux, linux-kernel, Geert Uytterhoeven

prom_meminit() and prom_ranges_init() are declared in <asm/oplib_32.h>.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--
Not even compile-tested

 arch/sparc/prom/init_32.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/sparc/prom/init_32.c b/arch/sparc/prom/init_32.c
index a8d9342..9ac30c2 100644
--- a/arch/sparc/prom/init_32.c
+++ b/arch/sparc/prom/init_32.c
@@ -31,9 +31,6 @@ struct linux_nodeops *prom_nodeops;
  * It gets passed the pointer to the PROM vector.
  */
 
-extern void prom_meminit(void);
-extern void prom_ranges_init(void);
-
 void __init prom_init(struct linux_romvec *rp)
 {
 	romvec = rp;
-- 
1.7.0.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] sparc: Correct comments about prom_init() return values
  2012-06-20 16:58 [PATCH 1/2] sparc: Correct comments about prom_init() return values Geert Uytterhoeven
  2012-06-20 16:58 ` [PATCH 2/2] sparc32: Remove superfluous extern declarations for prom_*() functions Geert Uytterhoeven
@ 2012-06-27  8:34 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-06-27  8:34 UTC (permalink / raw)
  To: geert; +Cc: sparclinux, linux-kernel

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 20 Jun 2012 18:58:06 +0200

> prom_init() returns void.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] sparc32: Remove superfluous extern declarations for prom_*() functions
  2012-06-20 16:58 ` [PATCH 2/2] sparc32: Remove superfluous extern declarations for prom_*() functions Geert Uytterhoeven
@ 2012-06-27  8:35   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-06-27  8:35 UTC (permalink / raw)
  To: geert; +Cc: sparclinux, linux-kernel

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 20 Jun 2012 18:58:07 +0200

> prom_meminit() and prom_ranges_init() are declared in <asm/oplib_32.h>.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-06-27  8:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-20 16:58 [PATCH 1/2] sparc: Correct comments about prom_init() return values Geert Uytterhoeven
2012-06-20 16:58 ` [PATCH 2/2] sparc32: Remove superfluous extern declarations for prom_*() functions Geert Uytterhoeven
2012-06-27  8:35   ` David Miller
2012-06-27  8:34 ` [PATCH 1/2] sparc: Correct comments about prom_init() return values David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®