[PATCH] mn10300: Fix pull clearing RESTORE_SIGMASK into block_sigmask() fallout

[PATCH] mn10300: Fix pull clearing RESTORE_SIGMASK into block_sigmask() fallout

[Geert Uytterhoeven]

commit a610d6e672d6d3723e8da257ad4a8a288a8f2f89 ("pull clearing
RESTORE_SIGMASK into block_sigmask()") caused:

arch/mn10300/kernel/signal.c: In function 'handle_signal':
arch/mn10300/kernel/signal.c:462:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]

Add the missing return values, and restore the indentation while we're at
it.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/mn10300/kernel/signal.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/mn10300/kernel/signal.c b/arch/mn10300/kernel/signal.c
index 6ab0bee..4d584ae 100644
--- a/arch/mn10300/kernel/signal.c
+++ b/arch/mn10300/kernel/signal.c
@@ -459,10 +459,11 @@ static int handle_signal(int sig,
 	else
 		ret = setup_frame(sig, ka, oldset, regs);
 	if (ret)
-		return;
+		return ret;
 
 	signal_delivered(sig, info, ka, regs,
-				 test_thread_flag(TIF_SINGLESTEP));
+			 test_thread_flag(TIF_SINGLESTEP));
+	return 0;
 }
 
 /*
-- 
1.7.0.4

Re: [PATCH] mn10300: Fix pull clearing RESTORE_SIGMASK into block_sigmask() fallout

[Geert Uytterhoeven]

Ping?

On Wed, Jun 20, 2012 at 9:19 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> commit a610d6e672d6d3723e8da257ad4a8a288a8f2f89 ("pull clearing
> RESTORE_SIGMASK into block_sigmask()") caused:
>
> arch/mn10300/kernel/signal.c: In function 'handle_signal':
> arch/mn10300/kernel/signal.c:462:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
>
> Add the missing return values, and restore the indentation while we're at
> it.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  arch/mn10300/kernel/signal.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mn10300/kernel/signal.c b/arch/mn10300/kernel/signal.c
> index 6ab0bee..4d584ae 100644
> --- a/arch/mn10300/kernel/signal.c
> +++ b/arch/mn10300/kernel/signal.c
> @@ -459,10 +459,11 @@ static int handle_signal(int sig,
>         else
>                 ret = setup_frame(sig, ka, oldset, regs);
>         if (ret)
> -               return;
> +               return ret;
>
>         signal_delivered(sig, info, ka, regs,
> -                                test_thread_flag(TIF_SINGLESTEP));
> +                        test_thread_flag(TIF_SINGLESTEP));
> +       return 0;
>  }
>
>  /*
> --
> 1.7.0.4

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds