From: "Henrik Rydberg" <rydberg@euromail.se>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jan Beulich <jbeulich@suse.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Henrik Rydberg <rydberg@euromail.se>
Subject: [PATCH] HID: Fix the Kconfig option for generic device handling
Date: Fri, 22 Jun 2012 11:13:10 +0200 [thread overview]
Message-ID: <1340356390-4614-1-git-send-email-rydberg@euromail.se> (raw)
The generic HID driver is obviously not a special driver, so move
it outside of the special drivers menu. Explain the usage and make
the default follow the HID setting. This should simplify migration
from older kernels.
Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
Hi Jiri,
As pointed out by Jan Beulich, the generic hid driver Kconfig option
is confusing. This patch ought to fix most of the concerns. For 3.5.
Thanks,
Henrik
drivers/hid/Kconfig | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 034c80a..fabf817 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -61,21 +61,22 @@ config HIDRAW
source "drivers/hid/usbhid/Kconfig"
-menu "Special HID drivers"
- depends on HID
-
config HID_GENERIC
tristate "Generic HID driver"
depends on HID
- default y
+ default HID
---help---
- Support for generic HID devices.
+ Support for generic devices on the HID bus. This includes most
+ keyboards and mice, joysticks, tablets and digitizers.
To compile this driver as a module, choose M here: the module
will be called hid-generic.
If unsure, say Y.
+menu "Special HID drivers"
+ depends on HID
+
config HID_A4TECH
tristate "A4 tech mice" if EXPERT
depends on USB_HID
--
1.7.10.4
next reply other threads:[~2012-06-22 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 9:13 Henrik Rydberg [this message]
2012-06-25 13:38 ` Jiri Kosina
2012-06-25 14:09 ` Henrik Rydberg
2012-06-25 15:16 ` Henrik Rydberg
2012-06-25 15:26 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340356390-4614-1-git-send-email-rydberg@euromail.se \
--to=rydberg@euromail.se \
--cc=dmitry.torokhov@gmail.com \
--cc=jbeulich@suse.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®