[PATCH] Staging: comedi: fixed print_k coding style issue in acl7225b.c

[PATCH] Staging: comedi: fixed print_k coding style issue in acl7225b.c

[Daniel Lawrence]

This is a patch to the acl7225b.c file that fixes up 2 print_k warnings
found by the checkpatch.pl tool.

Signed-off-by: Daniel Lawrence <daniel@danielscottlawrence.com>
---
 drivers/staging/comedi/drivers/acl7225b.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
index 4e4fc41..5392358 100644
--- a/drivers/staging/comedi/drivers/acl7225b.c
+++ b/drivers/staging/comedi/drivers/acl7225b.c
@@ -72,10 +72,10 @@ static int acl7225b_attach(struct comedi_device *dev,
 
 	iobase = it->options[0];
 	iorange = this_board->io_range;
-	printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
+	pr_info("comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
 	       this_board->name, iobase);
 	if (!request_region(iobase, iorange, "acl7225b")) {
-		printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n",
+		pr_err("comedi%d: request_region failed - I/O port conflict\n",
 			dev->minor);
 		return -EIO;
 	}
-- 
1.7.9.5

RE: [PATCH] Staging: comedi: fixed print_k coding style issue in acl7225b.c

[H Hartley Sweeten]

On Friday, June 22, 2012 6:00 AM, Danny Lawrence wrote:
> This is a patch to the acl7225b.c file that fixes up 2 print_k warnings
> found by the checkpatch.pl tool.
>
> Signed-off-by: Daniel Lawrence <daniel@danielscottlawrence.com>
> ---
>  drivers/staging/comedi/drivers/acl7225b.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
> index 4e4fc41..5392358 100644
> --- a/drivers/staging/comedi/drivers/acl7225b.c
> +++ b/drivers/staging/comedi/drivers/acl7225b.c
> @@ -72,10 +72,10 @@ static int acl7225b_attach(struct comedi_device *dev,
>  
>  	iobase = it->options[0];
>  	iorange = this_board->io_range;
> -	printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
> +	pr_info("comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
>  	       this_board->name, iobase);
>  	if (!request_region(iobase, iorange, "acl7225b")) {
> -		printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n",
> +		pr_err("comedi%d: request_region failed - I/O port conflict\n",
>  			dev->minor);
>  		return -EIO;
>  	}

Fixes to this type of issue in the comedi drivers should change the printk's
to the dev_printk style.

Hint, the format:

dev_info(dev->class_dev, "whatever\n");

Will automatically provide the "comedi%d: " part of the output.

Regards,
Hartley