mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
	peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
	eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com,
	sbw@mit.edu, patches@linaro.org,
	"Paul E. McKenney" <paul.mckenney@linaro.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 22/22] rcu: Prevent offline CPUs from executing RCU core code
Date: Fri, 22 Jun 2012 08:17:21 -0700	[thread overview]
Message-ID: <1340378241-6458-22-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1340378241-6458-1-git-send-email-paulmck@linux.vnet.ibm.com>

From: "Paul E. McKenney" <paul.mckenney@linaro.org>

Earlier versions of RCU invoked the RCU core from the CPU_DYING notifier
in order to note a quiescent state for the outgoing CPU.  Because the
CPU is marked "offline" during the execution of the CPU_DYING notifiers,
the RCU core had to tolerate being invoked from an offline CPU.  However,
commit b1420f1c (Make rcu_barrier() less disruptive) left only tracing
code in the CPU_DYING notifier, so the RCU core need no longer execute
on offline CPUs.  This commit therefore enforces this restriction.

Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcutree.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index d21c2d3..cbf4d05 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1880,6 +1880,8 @@ static void rcu_process_callbacks(struct softirq_action *unused)
 {
 	struct rcu_state *rsp;
 
+	if (cpu_is_offline(smp_processor_id()))
+		return;
 	trace_rcu_utilization("Start RCU core");
 	for_each_rcu_flavor(rsp)
 		__rcu_process_callbacks(rsp);
-- 
1.7.8


  parent reply	other threads:[~2012-06-22 15:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 15:16 [PATCH tip/core/rcu 0/22] v2 Improvements to rcu_barrier() and RT response on big systems Paul E. McKenney
2012-06-22 15:17 ` [PATCH tip/core/rcu 01/22] rcu: Control RCU_FANOUT_LEAF from boot-time parameter Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 02/22] rcu: Four-level hierarchy is no longer experimental Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 03/22] rcu: Size rcu_node tree from nr_cpu_ids rather than NR_CPUS Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 04/22] rcu: Prevent excessive line length in RCU_STATE_INITIALIZER() Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 05/22] rcu: Place pointer to call_rcu() in rcu_data structure Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 06/22] rcu: Move _rcu_barrier()'s rcu_head structures to rcu_data structures Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 07/22] rcu: Move rcu_barrier_cpu_count to rcu_state structure Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 08/22] rcu: Move rcu_barrier_completion " Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 09/22] rcu: Move rcu_barrier_mutex " Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 10/22] rcu: Remove needless initialization Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 11/22] rcu: Increase rcu_barrier() concurrency Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 12/22] rcu: Add tracing for _rcu_barrier() Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 13/22] rcu: Add rcu_barrier() statistics to debugfs tracing Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 14/22] rcu: Remove unneeded __rcu_process_callbacks() argument Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 15/22] rcu: Introduce for_each_rcu_flavor() and use it Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 16/22] rcu: Use for_each_rcu_flavor() in TREE_RCU tracing Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 17/22] rcu: RCU_SAVE_DYNTICK code no longer ever dead Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 18/22] rcu: Move RCU grace-period initialization into a kthread Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 19/22] rcu: Allow RCU grace-period initialization to be preempted Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 20/22] rcu: Move RCU grace-period cleanup into kthread Paul E. McKenney
2012-06-22 15:17   ` [PATCH tip/core/rcu 21/22] rcu: Allow RCU grace-period cleanup to be preempted Paul E. McKenney
2012-06-22 15:17   ` Paul E. McKenney [this message]
2012-07-01  6:19   ` [PATCH tip/core/rcu 01/22] rcu: Control RCU_FANOUT_LEAF from boot-time parameter Rusty Russell
2012-07-01  7:17     ` Josh Triplett
2012-07-01 12:52       ` Paul E. McKenney
2012-07-01 17:45         ` Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340378241-6458-22-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=darren@dvhart.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=patches@linaro.org \
    --cc=paul.mckenney@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sbw@mit.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®