mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joe Perches <joe@perches.com>
Subject: [PATCH] [SCSI] bnx2i: add a prefix to a printk
Date: Wed, 27 Jun 2012 21:26:51 +0200	[thread overview]
Message-ID: <1340825211.1911.42.camel@x61.thuisdomein> (raw)

During each suspend and resume cycle a mysterious message is added to
the logs:
    CPU 1 offline: Remove Rx thread

Some grepping of the tree revealed this message is printed by bnx2i.
Add a prefix to this message to make it clear that it is printed by
bnx2i. That should also make it obvious it is the mirror of the
    bnx2i: CPU 1 online: Create Rx thread

message.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Untested!

1) I only noticed this because I've been looking at the log messages
generated by suspend and resume (for some iwlegacy and i915 issues) and
because Fedora 16 enables bnx2i by default.

2) This triggers a checkpatch warning:
    WARNING: Prefer pr_info(... to printk(KERN_INFO, ...

So I added Joe to the Cc's to suggest a way to make all printks in this
file end up with a "bnx2i:" prefix (or whatever prefix is preferred).

 drivers/scsi/bnx2i/bnx2i_init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 8b68167..b75864b 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -456,7 +456,8 @@ static int bnx2i_cpu_callback(struct notifier_block *nfb,
 		break;
 	case CPU_DEAD:
 	case CPU_DEAD_FROZEN:
-		printk(KERN_INFO "CPU %x offline: Remove Rx thread\n", cpu);
+		printk(KERN_INFO "bnx2i: CPU %x offline: Remove Rx thread\n",
+			cpu);
 		bnx2i_percpu_thread_destroy(cpu);
 		break;
 	default:
-- 
1.7.7.6


             reply	other threads:[~2012-06-27 19:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 19:26 Paul Bolle [this message]
2013-11-21  8:34 ` Paul Bolle
2013-11-21  8:44   ` Richard Weinberger
2013-11-21  9:07   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340825211.1911.42.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=JBottomley@parallels.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®