From: Joerg Roedel <joerg.roedel@amd.com>
To: <iommu@lists.linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 07/28] iommu/amd: Introduce early_amd_iommu_init routine
Date: Thu, 5 Jul 2012 14:36:27 +0200 [thread overview]
Message-ID: <1341491808-23083-8-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1341491808-23083-1-git-send-email-joerg.roedel@amd.com>
Split out the code to parse the ACPI table and setup
relevant data structures into a new function.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
drivers/iommu/amd_iommu.c | 1 -
drivers/iommu/amd_iommu_init.c | 38 +++++++++++++++++++++++---------------
2 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index a2e418c..cfa01c4 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -382,7 +382,6 @@ DECLARE_STATS_COUNTER(invalidate_iotlb);
DECLARE_STATS_COUNTER(invalidate_iotlb_all);
DECLARE_STATS_COUNTER(pri_requests);
-
static struct dentry *stats_dir;
static struct dentry *de_fflush;
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index e6782fa..1b23235 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1494,17 +1494,14 @@ static void __init free_on_init_error(void)
* After everything is set up the IOMMUs are enabled and the necessary
* hotplug and suspend notifiers are registered.
*/
-int __init amd_iommu_init_hardware(void)
+static int __init early_amd_iommu_init(void)
{
struct acpi_table_header *ivrs_base;
acpi_size ivrs_size;
acpi_status status;
int i, ret = 0;
- if (no_iommu || (iommu_detected && !gart_iommu_aperture))
- return -ENODEV;
-
- if (amd_iommu_disabled || !amd_iommu_detected)
+ if (!amd_iommu_detected)
return -ENODEV;
if (amd_iommu_dev_table != NULL) {
@@ -1591,16 +1588,6 @@ int __init amd_iommu_init_hardware(void)
if (ret)
goto free;
- ret = amd_iommu_init_pci();
- if (ret)
- goto free;
-
- enable_iommus();
-
- amd_iommu_init_notifier();
-
- register_syscore_ops(&amd_iommu_syscore_ops);
-
out:
/* Don't leak any ACPI memory */
early_acpi_os_unmap_memory((char *)ivrs_base, ivrs_size);
@@ -1614,6 +1601,27 @@ free:
goto out;
}
+int amd_iommu_init_hardware(void)
+{
+ int ret = 0;
+
+ ret = early_amd_iommu_init();
+ if (ret)
+ return ret;
+
+ ret = amd_iommu_init_pci();
+ if (ret)
+ return ret;
+
+ enable_iommus();
+
+ amd_iommu_init_notifier();
+
+ register_syscore_ops(&amd_iommu_syscore_ops);
+
+ return ret;
+}
+
static int amd_iommu_enable_interrupts(void)
{
struct amd_iommu *iommu;
--
1.7.9.5
next prev parent reply other threads:[~2012-07-05 12:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 12:36 [PATCH 0/28] AMD IOMMU interrupt remapping support Joerg Roedel
2012-07-05 12:36 ` [PATCH 01/28] x86/irq: Add data structure to keep AMD specific irq remapping information Joerg Roedel
2012-07-05 12:36 ` [PATCH 02/28] x86/irq: Introduce irq_cfg->remapped Joerg Roedel
2012-07-05 12:36 ` [PATCH 03/28] x86/irq: Use irq_remap specific print_IO_APIC paths only on Intel Joerg Roedel
2012-07-06 8:50 ` Ingo Molnar
2012-07-06 13:05 ` Joerg Roedel
2012-07-06 14:00 ` Ingo Molnar
2012-07-09 12:32 ` Joerg Roedel
2012-07-05 12:36 ` [PATCH 04/28] iommu/amd: Use acpi_get_table instead of acpi_table_parse Joerg Roedel
2012-07-05 12:36 ` [PATCH 05/28] iommu/amd: Split out PCI related parts of IOMMU initialization Joerg Roedel
2012-07-05 12:36 ` [PATCH 06/28] iommu/amd: Move informational prinks out of iommu_enable Joerg Roedel
2012-07-06 4:08 ` Joe Perches
2012-07-06 12:08 ` Joerg Roedel
2012-07-05 12:36 ` Joerg Roedel [this message]
2012-07-05 12:36 ` [PATCH 08/28] iommu/amd: Split enable_iommus() routine Joerg Roedel
2012-07-05 12:36 ` [PATCH 09/28] iommu/amd: Move unmap_flush message to amd_iommu_init_dma_ops() Joerg Roedel
2012-07-05 12:36 ` [PATCH 10/28] iommu/amd: Introduce amd_iommu_init_dma routine Joerg Roedel
2012-07-05 12:36 ` [PATCH 11/28] iommu/amd: Convert iommu initialization to state machine Joerg Roedel
2012-07-05 12:36 ` [PATCH 12/28] iommu/amd: Keep track of HPET and IOAPIC device ids Joerg Roedel
2012-07-05 12:36 ` [PATCH 13/28] iommu/amd: Add slab-cache for irq remapping tables Joerg Roedel
2012-07-05 12:36 ` [PATCH 14/28] iommu/amd: Allocate data structures to keep track of " Joerg Roedel
2012-07-05 12:36 ` [PATCH 15/28] iommu/amd: Check if IOAPIC information is correct Joerg Roedel
2012-07-05 12:36 ` [PATCH 16/28] iommu/amd: Block all interrupts by default with irq-remapping enabled Joerg Roedel
2012-07-05 12:36 ` [PATCH 17/28] iommu/amd: Split device table initialization into irq and dma part Joerg Roedel
2012-07-06 13:08 ` Joerg Roedel
2012-07-05 12:36 ` [PATCH 18/28] iommu/amd: Make sure IOMMU is not considered to translate itself Joerg Roedel
2012-07-05 12:36 ` [PATCH 19/28] iommu/amd: Add IRTE invalidation routine Joerg Roedel
2012-07-05 12:36 ` [PATCH 20/28] iommu/amd: Add routines to manage irq remapping tables Joerg Roedel
2012-07-05 12:36 ` [PATCH 21/28] iommu/amd: Add IOAPIC remapping routines Joerg Roedel
2012-07-05 12:36 ` [PATCH 22/28] iommu/amd: Implement MSI routines for interrupt remapping Joerg Roedel
2012-07-05 12:36 ` [PATCH 23/28] iommu/amd: Add call-back routine for HPET MSI Joerg Roedel
2012-07-05 12:36 ` [PATCH 24/28] iommu/amd: Add initialization routines for AMD interrupt remapping Joerg Roedel
2012-07-05 12:36 ` [PATCH 25/28] iommu/amd: Make sure irq remapping still works on dma init failure Joerg Roedel
2012-07-05 12:36 ` [PATCH 26/28] iommu/irq: Use amd_iommu_irq_ops if supported Joerg Roedel
2012-07-05 12:36 ` [PATCH 27/28] iommu/amd: Print message to system log when irq remapping is enabled Joerg Roedel
2012-07-05 12:36 ` [PATCH 28/28] iommu/amd: Report irq remapping through IOMMU-API Joerg Roedel
2012-07-06 14:08 ` [PATCH 0/28] AMD IOMMU interrupt remapping support Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341491808-23083-8-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome