* [PATCH] m68k: Use PTR_RET rather than if(IS_ERR(.. [2]
@ 2012-08-06 17:51 Thomas Meyer
2012-08-18 13:20 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Meyer @ 2012-08-06 17:51 UTC (permalink / raw)
To: [geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org]
The semantic patch that makes this change is available
in scripts/coccinelle/api/ptr_ret.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c
--- a/arch/m68k/q40/config.c
+++ b/arch/m68k/q40/config.c
@@ -338,9 +338,6 @@ static __init int q40_add_kbd_device(voi
return -ENODEV;
pdev = platform_device_register_simple("q40kbd", -1, NULL, 0);
- if (IS_ERR(pdev))
- return PTR_ERR(pdev);
-
- return 0;
+ return PTR_RET(pdev);
}
arch_initcall(q40_add_kbd_device);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] m68k: Use PTR_RET rather than if(IS_ERR(.. [2]
2012-08-06 17:51 [PATCH] m68k: Use PTR_RET rather than if(IS_ERR(.. [2] Thomas Meyer
@ 2012-08-18 13:20 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2012-08-18 13:20 UTC (permalink / raw)
To: Thomas Meyer; +Cc: linux-m68k, linux-kernel
Thanks, applied and queued for 3.7.
On Mon, Aug 6, 2012 at 7:51 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/ptr_ret.cocci.
>
> More information about semantic patching is available at
> http://coccinelle.lip6.fr/
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c
> --- a/arch/m68k/q40/config.c
> +++ b/arch/m68k/q40/config.c
> @@ -338,9 +338,6 @@ static __init int q40_add_kbd_device(voi
> return -ENODEV;
>
> pdev = platform_device_register_simple("q40kbd", -1, NULL, 0);
> - if (IS_ERR(pdev))
> - return PTR_ERR(pdev);
> -
> - return 0;
> + return PTR_RET(pdev);
> }
> arch_initcall(q40_add_kbd_device);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-18 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-06 17:51 [PATCH] m68k: Use PTR_RET rather than if(IS_ERR(.. [2] Thomas Meyer
2012-08-18 13:20 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®