* [PATCH] PM / Domains: fix early device initialization failure
@ 2012-08-09 14:31 Marek Szyprowski
2012-08-09 19:30 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Marek Szyprowski @ 2012-08-09 14:31 UTC (permalink / raw)
To: linux-pm, linux-kernel; +Cc: Marek Szyprowski, Kyungmin Park, Rafael J. Wysocki
dev_pm_get_subsys_data() returns 1 when a new object has been created,
what should not be considered as an error for pm_genpd_add_device().
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/base/power/domain.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index ba3487c..6b61819 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1323,9 +1323,16 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
}
ret = dev_pm_get_subsys_data(dev);
- if (ret)
+
+ if (ret < 0)
goto out;
+ /*
+ * dev_pm_get_subsys_data() returns 1 when new object has been created
+ */
+ if (ret == 1)
+ ret = 0;
+
genpd->device_count++;
genpd->max_off_time_changed = true;
--
1.7.1.569.g6f426
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / Domains: fix early device initialization failure
2012-08-09 14:31 [PATCH] PM / Domains: fix early device initialization failure Marek Szyprowski
@ 2012-08-09 19:30 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2012-08-09 19:30 UTC (permalink / raw)
To: Marek Szyprowski; +Cc: linux-pm, linux-kernel, Kyungmin Park
On Thursday, August 09, 2012, Marek Szyprowski wrote:
> dev_pm_get_subsys_data() returns 1 when a new object has been created,
> what should not be considered as an error for pm_genpd_add_device().
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
This has been reported twice already and there's a patch in linux-next
to fix this issue. And your patch is incomplete. :-)
Thanks,
Rafael
> ---
> drivers/base/power/domain.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index ba3487c..6b61819 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1323,9 +1323,16 @@ int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev,
> }
>
> ret = dev_pm_get_subsys_data(dev);
> - if (ret)
> +
> + if (ret < 0)
> goto out;
>
> + /*
> + * dev_pm_get_subsys_data() returns 1 when new object has been created
> + */
> + if (ret == 1)
> + ret = 0;
> +
> genpd->device_count++;
> genpd->max_off_time_changed = true;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-09 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-09 14:31 [PATCH] PM / Domains: fix early device initialization failure Marek Szyprowski
2012-08-09 19:30 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®