mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joe Perches <joe@perches.com>,
	"Ren, Cloud" <cjren@qca.qualcomm.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	qca-linux-team <qca-linux-team@qualcomm.com>,
	nic-devel <nic-devel@qualcomm.com>,
	"Huang, Xiong" <xiong@qca.qualcomm.com>,
	"hao-ran.liu@canonical.com" <hao-ran.liu@canonical.com>,
	"Rodriguez, Luis" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH] net: add new QCA alx ethernet driver
Date: Thu, 9 Aug 2012 19:56:51 +0100	[thread overview]
Message-ID: <1344538611.2593.4.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1344526098.6935.44.camel@gandalf.stny.rr.com>

On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote:
> On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
> 
> > Yes, I sent signed-off patches to their original RFC submission
> > (back last year?).  To me, this single large patch is like a
> > snapshot of a git tree and not all contributors to that git
> > tree should be noted as signers of the entire thing.
> 
> Ouch, that looks like we are losing all history.
> 
> One large patch should not be submitted. If it was developed in steps,
> then it is best to show those steps when they are incorporated into the
> Linux repository.
> 
> Sure, the patches may be reworked and folded together where appropriate,
> but when I read "this single large patch is like a snapshot of a git
> tree", that right there is a red flag.

I don't think this has ever been a requirement for new drivers.

The alterations to the description of atl1c ought to be broken out as a
separate patch, though.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2012-08-09 18:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 10:14 cjren
2012-08-09  2:27 ` Ren, Cloud
2012-08-09  4:09   ` Joe Perches
2012-08-09  4:44     ` Ren, Cloud
2012-08-09  6:18       ` David Miller
2012-08-09  6:49         ` Ren, Cloud
2012-08-09  7:58           ` Joe Perches
2012-08-09  8:25             ` Ren, Cloud
2012-08-09 14:54           ` Steven Rostedt
2012-08-09 15:22             ` Joe Perches
2012-08-09 15:28               ` Steven Rostedt
2012-08-09 18:56                 ` Ben Hutchings [this message]
2012-08-10  0:26                   ` Huang, Xiong
2012-08-09 19:13                 ` Luis R. Rodriguez
2012-08-09 19:31                   ` Luis R. Rodriguez
2012-08-09  6:14     ` David Miller
2012-08-09  6:11   ` David Miller
2012-08-11 20:50 ` Stephen Hemminger
2012-08-13  1:19   ` Huang, Xiong
2012-08-15  3:29   ` Ren, Cloud
2012-08-15  5:32     ` David Miller
2012-08-15  5:39       ` Ren, Cloud
2012-08-15 15:02         ` Stephen Hemminger
2012-08-16  2:19           ` Ren, Cloud
2012-08-15 17:53 cjren
2012-08-16 13:16 ` Joe Perches
2012-08-17  1:49   ` Ren, Cloud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344538611.2593.4.camel@bwh-desktop.uk.solarflarecom.com \
    --to=bhutchings@solarflare.com \
    --cc=cjren@qca.qualcomm.com \
    --cc=davem@davemloft.net \
    --cc=hao-ran.liu@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic-devel@qualcomm.com \
    --cc=qca-linux-team@qualcomm.com \
    --cc=rodrigue@qca.qualcomm.com \
    --cc=rostedt@goodmis.org \
    --cc=xiong@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®