From: Stephen Hemminger <shemminger@vyatta.com>
To: "Ren, Cloud" <cjren@qca.qualcomm.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
qca-linux-team <qca-linux-team@qualcomm.com>,
nic-devel <nic-devel@qualcomm.com>,
"Huang, Xiong" <xiong@qca.qualcomm.com>,
"hao-ran.liu@canonical.com" <hao-ran.liu@canonical.com>,
"joe@perches.com" <joe@perches.com>,
"Rodriguez, Luis" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH] net: add new QCA alx ethernet driver
Date: Wed, 15 Aug 2012 08:02:26 -0700 [thread overview]
Message-ID: <20120815080226.388ea856@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <6349D7A510622448B1BA0967850A84380136A218@NASANEXD02D.na.qualcomm.com>
On Wed, 15 Aug 2012 05:39:11 +0000
"Ren, Cloud" <cjren@qca.qualcomm.com> wrote:
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, August 15, 2012 1:33 PM
>
> >From: "Ren, Cloud" <cjren@qca.qualcomm.com>
> >Date: Wed, 15 Aug 2012 03:29:26 +0000
> >
> >>>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
> >>>> ...
> >>>> + strcpy(netdev->name, "eth%d");
> >>>> + retval = register_netdev(netdev);
> >>>
> >>>The strcpy is unnecessary, alloc_etherdev already sets that.
> >>
> >> The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy
> >restores it.
> >
> >Are you doing this just to influence the initial driver log messages?
>
> Yes.
>
> >
> >Don't do that, it's gross.
>
> Ok, I will remove it.
Before the driver is registered, use dev_info() type of logging.
next prev parent reply other threads:[~2012-08-15 15:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 10:14 cjren
2012-08-09 2:27 ` Ren, Cloud
2012-08-09 4:09 ` Joe Perches
2012-08-09 4:44 ` Ren, Cloud
2012-08-09 6:18 ` David Miller
2012-08-09 6:49 ` Ren, Cloud
2012-08-09 7:58 ` Joe Perches
2012-08-09 8:25 ` Ren, Cloud
2012-08-09 14:54 ` Steven Rostedt
2012-08-09 15:22 ` Joe Perches
2012-08-09 15:28 ` Steven Rostedt
2012-08-09 18:56 ` Ben Hutchings
2012-08-10 0:26 ` Huang, Xiong
2012-08-09 19:13 ` Luis R. Rodriguez
2012-08-09 19:31 ` Luis R. Rodriguez
2012-08-09 6:14 ` David Miller
2012-08-09 6:11 ` David Miller
2012-08-11 20:50 ` Stephen Hemminger
2012-08-13 1:19 ` Huang, Xiong
2012-08-15 3:29 ` Ren, Cloud
2012-08-15 5:32 ` David Miller
2012-08-15 5:39 ` Ren, Cloud
2012-08-15 15:02 ` Stephen Hemminger [this message]
2012-08-16 2:19 ` Ren, Cloud
2012-08-15 17:53 cjren
2012-08-16 13:16 ` Joe Perches
2012-08-17 1:49 ` Ren, Cloud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815080226.388ea856@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=cjren@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=hao-ran.liu@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=xiong@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome