* [PATCH] usb: host: tegra: fix warning messages in ehci_remove
@ 2012-08-10 6:12 Venu Byravarasu
2012-08-10 13:51 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Venu Byravarasu @ 2012-08-10 6:12 UTC (permalink / raw)
To: stern, gregkh; +Cc: linux-kernel, linux-usb, Venu Byravarasu
Existing implementation of tegra_ehci_remove() calls
usb_put_hcd(hcd) first and then iounmap(hcd->regs).
usb_put_hcd() implementation calls hcd_release()
which frees up memory allocated for hcd.
As iounmap is trying to unmap hcd->regs, after hcd
getting freed up, warning messages were observed during
unload of USB.
Hence fixing it.
Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
drivers/usb/host/ehci-tegra.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 950e95e..26dedb3 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -799,11 +799,12 @@ static int tegra_ehci_remove(struct platform_device *pdev)
#endif
usb_remove_hcd(hcd);
- usb_put_hcd(hcd);
tegra_usb_phy_close(tegra->phy);
iounmap(hcd->regs);
+ usb_put_hcd(hcd);
+
clk_disable_unprepare(tegra->clk);
clk_put(tegra->clk);
--
1.7.1.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: host: tegra: fix warning messages in ehci_remove
2012-08-10 6:12 [PATCH] usb: host: tegra: fix warning messages in ehci_remove Venu Byravarasu
@ 2012-08-10 13:51 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2012-08-10 13:51 UTC (permalink / raw)
To: Venu Byravarasu; +Cc: gregkh, linux-kernel, linux-usb
On Fri, 10 Aug 2012, Venu Byravarasu wrote:
> Existing implementation of tegra_ehci_remove() calls
> usb_put_hcd(hcd) first and then iounmap(hcd->regs).
>
> usb_put_hcd() implementation calls hcd_release()
> which frees up memory allocated for hcd.
>
> As iounmap is trying to unmap hcd->regs, after hcd
> getting freed up, warning messages were observed during
> unload of USB.
>
> Hence fixing it.
>
> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
> ---
> drivers/usb/host/ehci-tegra.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 950e95e..26dedb3 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -799,11 +799,12 @@ static int tegra_ehci_remove(struct platform_device *pdev)
> #endif
>
> usb_remove_hcd(hcd);
> - usb_put_hcd(hcd);
>
> tegra_usb_phy_close(tegra->phy);
> iounmap(hcd->regs);
>
> + usb_put_hcd(hcd);
> +
> clk_disable_unprepare(tegra->clk);
> clk_put(tegra->clk);
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-10 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-10 6:12 [PATCH] usb: host: tegra: fix warning messages in ehci_remove Venu Byravarasu
2012-08-10 13:51 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®