From: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
To: Bryan O'Donoghue <bod@kernel.org>,
sakari.ailus@linux.intel.com, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: i2c: imx412: wait for NVM read (T7) before programming mode registers
Date: Mon, 12 Jan 2026 11:07:39 +0800 [thread overview]
Message-ID: <1344ad43-a4c4-4e37-ae4e-eddd2c577b3f@oss.qualcomm.com> (raw)
In-Reply-To: <dc68db73-163e-4443-b334-31e2ae529e99@kernel.org>
On 1/9/2026 8:32 PM, Bryan O'Donoghue wrote:
> This delay should go at the end of the operation that requires the delay
> not at the start of the streaming operation.
>
> The delay after the stream write, should be related to the stream write
> command, not the antecedent - the command that came before start_streaming.
>
> Basically I think you need to put your delay into the CCI_ID read NVM
> parameter load routine so that it guarantees its own completion.
>
> Because for argument's sake if start_streaming() were not to be the
> thing to happen after CCI_ID/NVM loading, the logic would no longer work.
>
> And you need a Fixes: tag for this patch too.
Reading the sensor ID only occurs during the sensor probe process. After
the probe is completed, the IMX577 will power down. When stream on
occurs, the driver will power on again and then start streaming, but the
sensor ID is not read during the stream on process.I have tested this
change on imx577 modules of different models.
So this change can only happen during power on or stream on.
Hi Bryan, Sakari,
May I ask if you have any suggestions regarding this?
Thanks,
Wenmeng
next prev parent reply other threads:[~2026-01-12 3:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tjF2Z2nt6dR-T_d-5cSpzZqItgoMsUzNmUBQ-jucG9SMQ9Q4y9cCrW4aya-hRJR0dQG-q63OBmZajTWMbxfeUA==@protonmail.internalid>
2026-01-09 4:49 ` Wenmeng Liu
2026-01-09 12:32 ` Bryan O'Donoghue
2026-01-12 3:07 ` Wenmeng Liu [this message]
2026-01-12 9:06 ` Sakari Ailus
2026-01-12 10:09 ` Wenmeng Liu
2026-01-12 10:21 ` Bryan O'Donoghue
2026-01-12 11:50 ` Wenmeng Liu
2026-01-12 11:59 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344ad43-a4c4-4e37-ae4e-eddd2c577b3f@oss.qualcomm.com \
--to=wenmeng.liu@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®