mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Wang <muming.wq@gmail.com>
To: peterz@infradead.org, linux-kernel@vger.kernel.org,
	mingo@redhat.com, dsmythies@telus.net
Cc: Charles Wang <muming.wq@gmail.com>, Charles Wang <muming.wq@taobao.com>
Subject: [PATCH] sched: add missing call for calc_load_exit_idle
Date: Mon, 20 Aug 2012 16:02:33 +0800	[thread overview]
Message-ID: <1345449754-27130-1-git-send-email-muming.wq@gmail.com> (raw)

>From Charles Wang <muming.wq@taobao.com>

Azat Khuzhin reported "high loadavg in linux-3.6"

After checking for upstream's code, I found Peter's patch
(Commit id:5167e8d5417bf5c322a703d2927daec727ea40dd) not be
fully applied, missing the call for calc_load_exit_idle.
After that idle exit in sampling window will always be calculated
 to non-idle, and the load will be higher than normal.

This patch add the missing call for calc_load_exit_idle.

Signed-off-by: Charles Wang <muming.wq@taobao.com>

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 024540f..3a9e5d5 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -573,6 +573,7 @@ static void tick_nohz_restart_sched_tick(struct tick_sched *ts, ktime_t now)
 	tick_do_update_jiffies64(now);
 	update_cpu_load_nohz();
 
+	calc_load_exit_idle();
 	touch_softlockup_watchdog();
 	/*
 	 * Cancel the scheduled timer and restore the tick
-- 
1.7.9.5


             reply	other threads:[~2012-08-20  8:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  8:02 Charles Wang [this message]
2012-08-20  8:13 ` Charles Wang
2012-08-20  8:39 ` Peter Zijlstra
2012-09-04 18:44 ` [tip:sched/core] sched: Add missing call to calc_load_exit_idle() tip-bot for Charles Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345449754-27130-1-git-send-email-muming.wq@gmail.com \
    --to=muming.wq@gmail.com \
    --cc=dsmythies@telus.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=muming.wq@taobao.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®