From: tip-bot for Charles Wang <muming.wq@taobao.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
muming.wq@taobao.com, a.p.zijlstra@chello.nl, tglx@linutronix.de
Subject: [tip:sched/core] sched: Add missing call to calc_load_exit_idle()
Date: Tue, 4 Sep 2012 11:44:49 -0700 [thread overview]
Message-ID: <tip-749c8814f08f12baa4a9c2812a7c6ede7d69507d@git.kernel.org> (raw)
In-Reply-To: <1345449754-27130-1-git-send-email-muming.wq@gmail.com>
Commit-ID: 749c8814f08f12baa4a9c2812a7c6ede7d69507d
Gitweb: http://git.kernel.org/tip/749c8814f08f12baa4a9c2812a7c6ede7d69507d
Author: Charles Wang <muming.wq@taobao.com>
AuthorDate: Mon, 20 Aug 2012 16:02:33 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 4 Sep 2012 14:30:29 +0200
sched: Add missing call to calc_load_exit_idle()
Azat Khuzhin reported high loadavg in Linux v3.6
After checking the upstream scheduler code, I found Peter's commit:
5167e8d5417b sched/nohz: Rewrite and fix load-avg computation -- again
not fully applied, missing the call to calc_load_exit_idle().
After that idle exit in sampling window will always be calculated
to non-idle, and the load will be higher than normal.
This patch adds the missing call to calc_load_exit_idle().
Signed-off-by: Charles Wang <muming.wq@taobao.com>
Cc: stable@kernel.org
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1345449754-27130-1-git-send-email-muming.wq@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/time/tick-sched.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 024540f..3a9e5d5 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -573,6 +573,7 @@ static void tick_nohz_restart_sched_tick(struct tick_sched *ts, ktime_t now)
tick_do_update_jiffies64(now);
update_cpu_load_nohz();
+ calc_load_exit_idle();
touch_softlockup_watchdog();
/*
* Cancel the scheduled timer and restore the tick
prev parent reply other threads:[~2012-09-04 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 8:02 [PATCH] sched: add missing call for calc_load_exit_idle Charles Wang
2012-08-20 8:13 ` Charles Wang
2012-08-20 8:39 ` Peter Zijlstra
2012-09-04 18:44 ` tip-bot for Charles Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-749c8814f08f12baa4a9c2812a7c6ede7d69507d@git.kernel.org \
--to=muming.wq@taobao.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome