From: Attilio Rao <attilio.rao@citrix.com>
To: <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
<hpa@zytor.com>, <tglx@linutronix.de>, <x86@kernel.org>,
<Stefano.Stabellini@eu.citrix.com>, <konrad.wilk@oracle.com>
Cc: Attilio Rao <attilio.rao@citrix.com>
Subject: [PATCH v4 0/2] XEN/X86: Document x86_init.mapping.pagetable_reserve and enforce a better semantic
Date: Wed, 22 Aug 2012 16:08:40 +0100 [thread overview]
Message-ID: <1345648122-11935-1-git-send-email-attilio.rao@citrix.com> (raw)
When looking for documenting x86_init.mapping.pagetable_reserve, I realized
that it assumes start == pgt_buf_start. I think this is not semantically right
(even if with the current code this should not be a problem in practice) and
what we really want is to extend the logic in order to do the RO -> RW
convertion also for the range [pgt_buf_start, start).
This patch then implements this missing conversion, adding some smaller
cleanups and finally provides documentation for the setup function.
Please look at 2/2 for more details on how the comment is structured.
If we get this right we will have a reference to be used later on for others
setup function pointers.
The difference with v1 is that sh_start local variable in
xen_mapping_pagetable_reserve() is renamed as begin. Also, the commit messages
have been tweaked.
The difference with v2 is that compiling warnings for x86_32 are fixed
about the usage of wrong format strings for panic() and pr_debug(). Also,
the range printing format has been unified and PFN_PHYS() members are
casted to u64 on printing, to remain consistent (which is basically
what also lib/swiotlb.c does.
The difference with v3 is tweaks in commit logs, avoiding bogus reference
to the word PVOPS.
Attilio Rao (2):
XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve
XEN: Document the semantic of x86_init.mapping.pagetable_reserve
arch/x86/include/asm/x86_init.h | 19 +++++++++++++++++--
arch/x86/mm/init.c | 4 ++++
arch/x86/xen/mmu.c | 22 ++++++++++++++++++++--
3 files changed, 41 insertions(+), 4 deletions(-)
--
1.7.2.5
next reply other threads:[~2012-08-22 15:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 15:08 Attilio Rao [this message]
2012-08-22 15:08 ` [PATCH v4 1/2] XEN/X86: Improve semantic support for x86_init.mapping.pagetable_reserve Attilio Rao
2012-08-23 15:46 ` Thomas Gleixner
2012-08-23 15:44 ` Attilio Rao
2012-08-23 17:14 ` Thomas Gleixner
2012-08-23 17:13 ` Attilio Rao
2012-08-24 10:03 ` Borislav Petkov
2012-08-24 10:10 ` Attilio Rao
2012-08-24 11:36 ` Konrad Rzeszutek Wilk
2012-08-24 11:57 ` Stefano Stabellini
2012-08-24 13:00 ` Thomas Gleixner
2012-08-24 13:24 ` Attilio Rao
2012-08-24 13:45 ` Borislav Petkov
2012-08-24 15:18 ` Thomas Gleixner
2012-08-24 13:32 ` Stefano Stabellini
2012-08-24 15:20 ` Thomas Gleixner
2012-08-24 17:27 ` Stefano Stabellini
2012-08-24 20:10 ` Thomas Gleixner
2012-08-22 15:08 ` [PATCH v4 2/2] XEN: Document the semantic of x86_init.mapping.pagetable_reserve Attilio Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345648122-11935-1-git-send-email-attilio.rao@citrix.com \
--to=attilio.rao@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®