From: Steven Rostedt <rostedt@goodmis.org>
To: Adam Lee <adam8157@gmail.com>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Yaakov Selkowitz <yselkowitz@users.sourceforge.net>,
Peter Foley <pefoley2@verizon.net>,
Paul Bolle <pebolle@tiscali.nl>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"open list:KCONFIG" <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] kconfig: replace 'oldnoconfig' with 'olddefconfig', what it really does
Date: Thu, 23 Aug 2012 16:10:01 -0400 [thread overview]
Message-ID: <1345752601.12440.3.camel@gandalf.local.home> (raw)
In-Reply-To: <1345187778-19678-1-git-send-email-adam8157@gmail.com>
Sorry for the late reply.
On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
> set new symbols to 'n', but instead sets it to their default values.
>
> So, this patch replace 'oldnoconfig' with 'olddefconfig', stop making
> people confused.
>
> PS: the document in conf.c fixed in another mail, "[PATCH] [Signed-off]
> kconfig: document oldnoconfig to what it really does in conf.c"
The reason that I didn't make this change myself is that I'm afraid that
things depend on 'oldnoconfig' existing. For example, ktest.pl has it
hardcoded. That may not be the only script that uses it.
I think a better solution would be to make oldnoconfig do just that, set
everything to 'n' as the name implies, and we can create a olddefconfig
to do what it does now.
-- Steve
>
> Signed-off-by: Adam Lee <adam8157@gmail.com>
> ---
> scripts/kconfig/Makefile | 6 +++---
> scripts/kconfig/conf.c | 18 +++++++++---------
> tools/testing/ktest/ktest.pl | 15 +++++++--------
> 3 files changed, 19 insertions(+), 20 deletions(-)
>
next prev parent reply other threads:[~2012-08-23 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 7:16 Adam Lee
2012-08-23 20:10 ` Steven Rostedt [this message]
2012-08-24 3:05 ` Adam Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345752601.12440.3.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=adam8157@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pebolle@tiscali.nl \
--cc=pefoley2@verizon.net \
--cc=yselkowitz@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®