mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacob Shin <jacob.shin@amd.com>
To: X86-ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>,
	Tejun Heo <tj@kernel.org>, Dave Young <dyoung@redhat.com>,
	Chao Wang <chaowang@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
	Andreas Herrmann <andreas.herrmann3@amd.com>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Jacob Shin <jacob.shin@amd.com>
Subject: [PATCH 1/5] x86: Move enabling of PSE and PGE out of init_memory_mapping
Date: Fri, 24 Aug 2012 18:55:12 -0500	[thread overview]
Message-ID: <1345852516-3125-2-git-send-email-jacob.shin@amd.com> (raw)
In-Reply-To: <1345852516-3125-1-git-send-email-jacob.shin@amd.com>

Depending on the platform, init_memory_mapping() may be called multiple
times. Move it out to setup_arch() to avoid writing to cr4 on every call.

Signed-off-by: Jacob Shin <jacob.shin@amd.com>
---
 arch/x86/kernel/setup.c |   10 ++++++++++
 arch/x86/mm/init.c      |   10 ----------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index f4b9b80..751e020 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -913,6 +913,16 @@ void __init setup_arch(char **cmdline_p)
 
 	init_gbpages();
 
+	/* Enable PSE if available */
+	if (cpu_has_pse)
+		set_in_cr4(X86_CR4_PSE);
+
+	/* Enable PGE if available */
+	if (cpu_has_pge) {
+		set_in_cr4(X86_CR4_PGE);
+		__supported_pte_mask |= _PAGE_GLOBAL;
+	}
+
 	/* max_pfn_mapped is updated here */
 	max_low_pfn_mapped = init_memory_mapping(0, max_low_pfn<<PAGE_SHIFT);
 	max_pfn_mapped = max_low_pfn_mapped;
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index e0e6990..2f07e09 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -149,16 +149,6 @@ unsigned long __init_refok init_memory_mapping(unsigned long start,
 	use_gbpages = direct_gbpages;
 #endif
 
-	/* Enable PSE if available */
-	if (cpu_has_pse)
-		set_in_cr4(X86_CR4_PSE);
-
-	/* Enable PGE if available */
-	if (cpu_has_pge) {
-		set_in_cr4(X86_CR4_PGE);
-		__supported_pte_mask |= _PAGE_GLOBAL;
-	}
-
 	if (use_gbpages)
 		page_size_mask |= 1 << PG_LEVEL_1G;
 	if (use_pse)
-- 
1.7.9.5



  reply	other threads:[~2012-08-24 23:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 23:55 [PATCH V4 0/5] x86: Create direct mappings for E820_RAM only Jacob Shin
2012-08-24 23:55 ` Jacob Shin [this message]
2012-08-25  1:25   ` [PATCH 1/5] x86: Move enabling of PSE and PGE out of init_memory_mapping Yinghai Lu
2012-08-25  1:49     ` Yinghai Lu
2012-08-25  2:06       ` Yinghai Lu
2012-08-25  4:15         ` Jacob Shin
2012-08-25  4:13     ` Jacob Shin
2012-08-24 23:55 ` [PATCH 2/5] x86: find_early_table_space based on memory ranges that are being mapped Jacob Shin
2012-10-21 21:22   ` Tom Rini
2012-08-24 23:55 ` [PATCH 3/5] x86: Only direct map addresses that are marked as E820_RAM Jacob Shin
2012-08-25  0:17   ` Jacob Shin
2012-08-25  0:30   ` H. Peter Anvin
2012-08-25  0:49     ` Jacob Shin
2012-08-25  1:13       ` H. Peter Anvin
2012-08-25  4:20         ` Jacob Shin
2012-08-25  4:21           ` H. Peter Anvin
2012-08-27 19:17             ` Jacob Shin
2012-08-27 20:15               ` H. Peter Anvin
2012-08-25  1:07   ` Yinghai Lu
2012-08-25  4:24     ` Jacob Shin
2012-08-25  4:54       ` Yinghai Lu
2012-08-27 18:49         ` Jacob Shin
2012-08-27 20:16           ` H. Peter Anvin
2012-08-28 16:06         ` Jacob Shin
2012-08-28 16:11           ` H. Peter Anvin
2012-08-24 23:55 ` [PATCH 4/5] x86: Fixup code testing if a pfn is direct mapped Jacob Shin
2012-08-24 23:55 ` [PATCH 5/5] x86: if kernel .text .data .bss are not marked as E820_RAM, complain and fix Jacob Shin
2012-08-25  1:23   ` Yinghai Lu
2012-08-25  4:25     ` Jacob Shin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345852516-3125-2-git-send-email-jacob.shin@amd.com \
    --to=jacob.shin@amd.com \
    --cc=andreas.herrmann3@amd.com \
    --cc=borislav.petkov@amd.com \
    --cc=chaowang@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome