From: Jacob Shin <jacob.shin@amd.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: X86-ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>, Tejun Heo <tj@kernel.org>,
Dave Young <dyoung@redhat.com>, Chao Wang <chaowang@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH 3/5] x86: Only direct map addresses that are marked as E820_RAM
Date: Fri, 24 Aug 2012 23:20:20 -0500 [thread overview]
Message-ID: <20120825042020.GC26127@jshin-Toonie> (raw)
In-Reply-To: <5038269E.80707@zytor.com>
On Fri, Aug 24, 2012 at 06:13:02PM -0700, H. Peter Anvin wrote:
> On 08/24/2012 05:49 PM, Jacob Shin wrote:
> >
> > Right, I think what I was attempting to do was to merge the 1MB
> > with E820_RAM right above 1MB:
> >
> > So instead of:
> >
> > init_memory_mapping(0, 1MB)
> > init_memory_mapping(1MB, 2GB)
> >
> > It would be:
> >
> > init_memory_mapping(0, 2GB)
> >
> > While taking care of the odd case where there is a gap right after
> > 1MB.
> >
> > But if its not worth it, I can move it out of the loop.
> >
>
> What is the benefit?
So that in the case where we have E820_RAM right above 1MB, we don't
call init_memory_mapping twice, first on 0 ~ 1MB and then 1MB ~ something
we only call it once. 0 ~ something.
I'll get it out of the loop if you don't think its a good idea.
>
> -hpa
>
>
next prev parent reply other threads:[~2012-08-25 4:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 23:55 [PATCH V4 0/5] x86: Create direct mappings for E820_RAM only Jacob Shin
2012-08-24 23:55 ` [PATCH 1/5] x86: Move enabling of PSE and PGE out of init_memory_mapping Jacob Shin
2012-08-25 1:25 ` Yinghai Lu
2012-08-25 1:49 ` Yinghai Lu
2012-08-25 2:06 ` Yinghai Lu
2012-08-25 4:15 ` Jacob Shin
2012-08-25 4:13 ` Jacob Shin
2012-08-24 23:55 ` [PATCH 2/5] x86: find_early_table_space based on memory ranges that are being mapped Jacob Shin
2012-10-21 21:22 ` Tom Rini
2012-08-24 23:55 ` [PATCH 3/5] x86: Only direct map addresses that are marked as E820_RAM Jacob Shin
2012-08-25 0:17 ` Jacob Shin
2012-08-25 0:30 ` H. Peter Anvin
2012-08-25 0:49 ` Jacob Shin
2012-08-25 1:13 ` H. Peter Anvin
2012-08-25 4:20 ` Jacob Shin [this message]
2012-08-25 4:21 ` H. Peter Anvin
2012-08-27 19:17 ` Jacob Shin
2012-08-27 20:15 ` H. Peter Anvin
2012-08-25 1:07 ` Yinghai Lu
2012-08-25 4:24 ` Jacob Shin
2012-08-25 4:54 ` Yinghai Lu
2012-08-27 18:49 ` Jacob Shin
2012-08-27 20:16 ` H. Peter Anvin
2012-08-28 16:06 ` Jacob Shin
2012-08-28 16:11 ` H. Peter Anvin
2012-08-24 23:55 ` [PATCH 4/5] x86: Fixup code testing if a pfn is direct mapped Jacob Shin
2012-08-24 23:55 ` [PATCH 5/5] x86: if kernel .text .data .bss are not marked as E820_RAM, complain and fix Jacob Shin
2012-08-25 1:23 ` Yinghai Lu
2012-08-25 4:25 ` Jacob Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120825042020.GC26127@jshin-Toonie \
--to=jacob.shin@amd.com \
--cc=andreas.herrmann3@amd.com \
--cc=borislav.petkov@amd.com \
--cc=chaowang@redhat.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®