* [PATCH 3/3] fat: simplify writeback_inode function.
@ 2012-08-25 8:23 Namjae Jeon
2012-08-26 14:05 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2012-08-25 8:23 UTC (permalink / raw)
To: hirofumi, akpm; +Cc: linux-kernel, Namjae Jeon, Amit Sahrawat
Simplify writeback_inode function.
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
---
fs/fat/inode.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 973296b..4bbb24e 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1457,18 +1457,14 @@ static int writeback_inode(struct inode *inode)
{
int ret;
- struct address_space *mapping = inode->i_mapping;
- struct writeback_control wbc = {
- .sync_mode = WB_SYNC_NONE,
- .nr_to_write = 0,
- };
- /* if we used WB_SYNC_ALL, sync_inode waits for the io for the
- * inode to finish. So WB_SYNC_NONE is sent down to sync_inode
+
+ /* if we used wait=1, sync_inode_metadata waits for the io for the
+ * inode to finish. So wait=0 is sent down to sync_inode_metadata
* and filemap_fdatawrite is used for the data blocks
*/
- ret = sync_inode(inode, &wbc);
+ ret = sync_inode_metadata(inode, 0);
if (!ret)
- ret = filemap_fdatawrite(mapping);
+ ret = filemap_fdatawrite(inode->i_mapping);
return ret;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 3/3] fat: simplify writeback_inode function.
2012-08-25 8:23 [PATCH 3/3] fat: simplify writeback_inode function Namjae Jeon
@ 2012-08-26 14:05 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2012-08-26 14:05 UTC (permalink / raw)
To: Namjae Jeon; +Cc: akpm, linux-kernel, Amit Sahrawat
Namjae Jeon <linkinjeon@gmail.com> writes:
> Simplify writeback_inode function.
Looks cleanup without logic change.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
> fs/fat/inode.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 973296b..4bbb24e 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1457,18 +1457,14 @@ static int writeback_inode(struct inode *inode)
> {
>
> int ret;
> - struct address_space *mapping = inode->i_mapping;
> - struct writeback_control wbc = {
> - .sync_mode = WB_SYNC_NONE,
> - .nr_to_write = 0,
> - };
> - /* if we used WB_SYNC_ALL, sync_inode waits for the io for the
> - * inode to finish. So WB_SYNC_NONE is sent down to sync_inode
> +
> + /* if we used wait=1, sync_inode_metadata waits for the io for the
> + * inode to finish. So wait=0 is sent down to sync_inode_metadata
> * and filemap_fdatawrite is used for the data blocks
> */
> - ret = sync_inode(inode, &wbc);
> + ret = sync_inode_metadata(inode, 0);
> if (!ret)
> - ret = filemap_fdatawrite(mapping);
> + ret = filemap_fdatawrite(inode->i_mapping);
> return ret;
> }
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-26 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-25 8:23 [PATCH 3/3] fat: simplify writeback_inode function Namjae Jeon
2012-08-26 14:05 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®