* [PATCH] tracing: skip printing "OK" if failed to disable event
@ 2012-08-27 7:13 Yuanhan Liu
2012-09-14 11:40 ` [tip:perf/core] tracing: Skip " tip-bot for Yuanhan Liu
0 siblings, 1 reply; 2+ messages in thread
From: Yuanhan Liu @ 2012-08-27 7:13 UTC (permalink / raw)
To: linux-kernel; +Cc: rostedt, Yuanhan Liu
No acutal case found. But logically, we should skip "OK" in case any
error met.
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
kernel/trace/trace_events.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 29111da..9894162 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1646,9 +1646,11 @@ static __init void event_trace_self_tests(void)
event_test_stuff();
ret = __ftrace_set_clr_event(NULL, system->name, NULL, 0);
- if (WARN_ON_ONCE(ret))
+ if (WARN_ON_ONCE(ret)) {
pr_warning("error disabling system %s\n",
system->name);
+ continue;
+ }
pr_cont("OK\n");
}
--
1.7.7.6
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:perf/core] tracing: Skip printing "OK" if failed to disable event
2012-08-27 7:13 [PATCH] tracing: skip printing "OK" if failed to disable event Yuanhan Liu
@ 2012-09-14 11:40 ` tip-bot for Yuanhan Liu
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Yuanhan Liu @ 2012-09-14 11:40 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, yuanhan.liu, rostedt, tglx
Commit-ID: 76bab1b78ab6f25d5f74165f94526c25fc93d984
Gitweb: http://git.kernel.org/tip/76bab1b78ab6f25d5f74165f94526c25fc93d984
Author: Yuanhan Liu <yuanhan.liu@linux.intel.com>
AuthorDate: Mon, 27 Aug 2012 15:13:45 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu, 13 Sep 2012 22:52:07 -0400
tracing: Skip printing "OK" if failed to disable event
No acutal case found. But logically, we should skip "OK" in case any
error met.
Link: http://lkml.kernel.org/r/1346051625-25231-1-git-send-email-yuanhan.liu@linux.intel.com
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_events.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 6825d83..bbb0e63 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1646,9 +1646,11 @@ static __init void event_trace_self_tests(void)
event_test_stuff();
ret = __ftrace_set_clr_event(NULL, system->name, NULL, 0);
- if (WARN_ON_ONCE(ret))
+ if (WARN_ON_ONCE(ret)) {
pr_warning("error disabling system %s\n",
system->name);
+ continue;
+ }
pr_cont("OK\n");
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-14 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-27 7:13 [PATCH] tracing: skip printing "OK" if failed to disable event Yuanhan Liu
2012-09-14 11:40 ` [tip:perf/core] tracing: Skip " tip-bot for Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®