mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: linux-kernel@vger.kernel.org
Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: [PATCH 2/5] net:atm:fix up ENOIOCTLCMD error handling
Date: Mon, 27 Aug 2012 15:23:13 +0800	[thread overview]
Message-ID: <1346052196-32682-3-git-send-email-gaowanlong@cn.fujitsu.com> (raw)
In-Reply-To: <1346052196-32682-1-git-send-email-gaowanlong@cn.fujitsu.com>

At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
 net/atm/resources.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/atm/resources.c b/net/atm/resources.c
index 23f45ce..0447d5d 100644
--- a/net/atm/resources.c
+++ b/net/atm/resources.c
@@ -432,7 +432,7 @@ int atm_dev_ioctl(unsigned int cmd, void __user *arg, int compat)
 			size = dev->ops->ioctl(dev, cmd, buf);
 		}
 		if (size < 0) {
-			error = (size == -ENOIOCTLCMD ? -EINVAL : size);
+			error = (size == -ENOIOCTLCMD ? -ENOTTY : size);
 			goto done;
 		}
 	}
-- 
1.7.12


  parent reply	other threads:[~2012-08-27  7:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27  7:23 [PATCH 0/5] drivers: fix " Wanlong Gao
2012-08-27  7:23 ` [PATCH 1/5] drivers:tty:fix " Wanlong Gao
2012-08-27 22:42   ` Alan Cox
2012-08-27  7:23 ` Wanlong Gao [this message]
2012-08-31 20:14   ` [PATCH 2/5] net:atm:fix " David Miller
2012-08-27  7:23 ` [PATCH 3/5] media:dvb:fix " Wanlong Gao
2012-08-27  7:23 ` [PATCH 4/5] video:omap3isp:fix " Wanlong Gao
2012-09-13  4:03   ` Laurent Pinchart
2012-09-13 10:21     ` Wanlong Gao
2012-08-27  7:23 ` [PATCH 5/5] s390:block:fix " Wanlong Gao
2012-08-27  9:03   ` Heiko Carstens
2012-08-27 10:25     ` Stefan Weinhuber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346052196-32682-3-git-send-email-gaowanlong@cn.fujitsu.com \
    --to=gaowanlong@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®