mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/5] drivers:tty:fix up ENOIOCTLCMD error handling
Date: Mon, 27 Aug 2012 23:42:31 +0100	[thread overview]
Message-ID: <20120827234231.18b971f5@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1346052196-32682-2-git-send-email-gaowanlong@cn.fujitsu.com>

On Mon, 27 Aug 2012 15:23:12 +0800
Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:

> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> translated as ENOTTY to user mode.
> For example:
> 	fd = open("/dev/tty", O_RDWR);
> 	ioctl(fd, -1, &argp);
> 
> then the errno should be ENOTTY but not EINVAL.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Acked-by: Alan Cox <alan@linux.intel.com>

  reply	other threads:[~2012-08-27 22:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27  7:23 [PATCH 0/5] drivers: fix " Wanlong Gao
2012-08-27  7:23 ` [PATCH 1/5] drivers:tty:fix " Wanlong Gao
2012-08-27 22:42   ` Alan Cox [this message]
2012-08-27  7:23 ` [PATCH 2/5] net:atm:fix " Wanlong Gao
2012-08-31 20:14   ` David Miller
2012-08-27  7:23 ` [PATCH 3/5] media:dvb:fix " Wanlong Gao
2012-08-27  7:23 ` [PATCH 4/5] video:omap3isp:fix " Wanlong Gao
2012-09-13  4:03   ` Laurent Pinchart
2012-09-13 10:21     ` Wanlong Gao
2012-08-27  7:23 ` [PATCH 5/5] s390:block:fix " Wanlong Gao
2012-08-27  9:03   ` Heiko Carstens
2012-08-27 10:25     ` Stefan Weinhuber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120827234231.18b971f5@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®