From: Davidlohr Bueso <dave@gnu.org>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>, stable@vger.kernel.org
Subject: [PATCH v2] lib: gcd: prevent possible div by 0
Date: Mon, 10 Sep 2012 16:35:19 +0200 [thread overview]
Message-ID: <1347287719.2561.14.camel@offbook> (raw)
Account for all properties when a and/or b are 0:
gcd(0, 0) = 0
gcd(a, 0) = a
gcd(0, b) = b
Cc: stable@vger.kernel.org
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
V2: simplified checking with b = 0 (Eric)
lib/gcd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/gcd.c b/lib/gcd.c
index cce4f3c..3657f12 100644
--- a/lib/gcd.c
+++ b/lib/gcd.c
@@ -9,6 +9,9 @@ unsigned long gcd(unsigned long a, unsigned long b)
if (a < b)
swap(a, b);
+
+ if (!b)
+ return a;
while ((r = a % b) != 0) {
a = b;
b = r;
--
1.7.9.5
next reply other threads:[~2012-09-10 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 14:35 Davidlohr Bueso [this message]
2012-09-12 19:05 ` Davidlohr Bueso
2012-09-12 19:36 ` Greg Kroah-Hartman
2012-09-12 19:10 ` Andrew Morton
2012-09-12 19:20 ` Davidlohr Bueso
2012-09-12 19:36 ` Andrew Morton
2012-09-12 20:30 ` Davidlohr Bueso
2012-09-12 21:38 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347287719.2561.14.camel@offbook \
--to=dave@gnu.org \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome