From: Andrew Morton <akpm@linux-foundation.org>
To: dave@gnu.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] lib: gcd: prevent possible div by 0
Date: Wed, 12 Sep 2012 12:10:55 -0700 [thread overview]
Message-ID: <20120912121055.bd417043.akpm@linux-foundation.org> (raw)
In-Reply-To: <1347287719.2561.14.camel@offbook>
On Mon, 10 Sep 2012 16:35:19 +0200
Davidlohr Bueso <dave@gnu.org> wrote:
> Account for all properties when a and/or b are 0:
> gcd(0, 0) = 0
> gcd(a, 0) = a
> gcd(0, b) = b
>
> Cc: stable@vger.kernel.org
Why cc:stable? If this patch fixes some known problem in the current
kernel then that really really should have been described in the
changelog. Always. Please.
> ...
> --- a/lib/gcd.c
> +++ b/lib/gcd.c
> @@ -9,6 +9,9 @@ unsigned long gcd(unsigned long a, unsigned long b)
>
> if (a < b)
> swap(a, b);
> +
> + if (!b)
> + return a;
> while ((r = a % b) != 0) {
> a = b;
> b = r;
> --
> 1.7.9.5
>
>
next prev parent reply other threads:[~2012-09-12 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 14:35 Davidlohr Bueso
2012-09-12 19:05 ` Davidlohr Bueso
2012-09-12 19:36 ` Greg Kroah-Hartman
2012-09-12 19:10 ` Andrew Morton [this message]
2012-09-12 19:20 ` Davidlohr Bueso
2012-09-12 19:36 ` Andrew Morton
2012-09-12 20:30 ` Davidlohr Bueso
2012-09-12 21:38 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912121055.bd417043.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@gnu.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome