* [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code
@ 2012-09-17 8:14 Peter Senna Tschudin
2012-09-18 12:27 ` Bounine, Alexandre
0 siblings, 1 reply; 2+ messages in thread
From: Peter Senna Tschudin @ 2012-09-17 8:14 UTC (permalink / raw)
To: mporter
Cc: alexandre.bounine, akpm, chul.kim, jiang.liu, bhelgaas,
linux-kernel, kernel-janitors, Peter Senna Tschudin
From: Peter Senna Tschudin <peter.senna@gmail.com>
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/rapidio/devices/tsi721.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
index 1974359..78dff6f 100644
--- a/drivers/rapidio/devices/tsi721.c
+++ b/drivers/rapidio/devices/tsi721.c
@@ -2316,7 +2316,8 @@ static int __devinit tsi721_probe(struct pci_dev *pdev,
/* Configure DMA attributes. */
if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
- if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) {
+ err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
+ if (err) {
dev_info(&pdev->dev, "Unable to set DMA mask\n");
goto err_unmap_bars;
}
--
1.7.11.4
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code
2012-09-17 8:14 [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code Peter Senna Tschudin
@ 2012-09-18 12:27 ` Bounine, Alexandre
0 siblings, 0 replies; 2+ messages in thread
From: Bounine, Alexandre @ 2012-09-18 12:27 UTC (permalink / raw)
To: Peter Senna Tschudin, mporter
Cc: akpm, chul.kim, jiang.liu, bhelgaas, linux-kernel, kernel-janitors
On Monday, Sep.17, at 2012 4:14 AM Peter Senna Tschudin wrote:
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
... skip ...
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/rapidio/devices/tsi721.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rapidio/devices/tsi721.c
> b/drivers/rapidio/devices/tsi721.c
> index 1974359..78dff6f 100644
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -2316,7 +2316,8 @@ static int __devinit tsi721_probe(struct pci_dev
> *pdev,
>
> /* Configure DMA attributes. */
> if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
> - if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) {
> + err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
> + if (err) {
> dev_info(&pdev->dev, "Unable to set DMA mask\n");
> goto err_unmap_bars;
> }
> --
> 1.7.11.4
Acked-by: Alexandre Bounine <alexandre.bounine@idt.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-18 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-17 8:14 [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code Peter Senna Tschudin
2012-09-18 12:27 ` Bounine, Alexandre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome