From: Ben Hutchings <bhutchings@solarflare.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<havard@skinnemoen.net>, <linux-arm-kernel@lists.infradead.org>,
<plagnioj@jcrosoft.com>, <patrice.vilchez@atmel.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/9] net/macb: remove macb_get_drvinfo()
Date: Wed, 19 Sep 2012 16:10:54 +0100 [thread overview]
Message-ID: <1348067454.4836.56.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <3fbd9b0eb1e255eccd14ad43044e146776baa963.1348055112.git.nicolas.ferre@atmel.com>
On Wed, 2012-09-19 at 13:55 +0200, Nicolas Ferre wrote:
> This function has little meaning so remove it altogether and
> let ethtool core fill in the fields automatically.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/net/ethernet/cadence/macb.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 2948553..31f945c 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1217,20 +1217,9 @@ static int macb_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> return phy_ethtool_sset(phydev, cmd);
> }
>
> -static void macb_get_drvinfo(struct net_device *dev,
> - struct ethtool_drvinfo *info)
> -{
> - struct macb *bp = netdev_priv(dev);
> -
> - strcpy(info->driver, bp->pdev->dev.driver->name);
> - strcpy(info->version, "$Revision: 1.14 $");
> - strcpy(info->bus_info, dev_name(&bp->pdev->dev));
> -}
> -
> static const struct ethtool_ops macb_ethtool_ops = {
> .get_settings = macb_get_settings,
> .set_settings = macb_set_settings,
> - .get_drvinfo = macb_get_drvinfo,
> .get_link = ethtool_op_get_link,
> };
>
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-09-19 15:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:55 [PATCH v2 0/9] net/macb: driver enhancement concerning GEM support, ring logic and cleanup Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 1/9] net/macb: Add support for Gigabit Ethernet mode Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 2/9] net/macb: memory barriers cleanup Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 3/9] net/macb: change debugging messages Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 4/9] net/macb: remove macb_get_drvinfo() Nicolas Ferre
2012-09-19 15:10 ` Ben Hutchings [this message]
2012-09-19 11:55 ` [PATCH v2 5/9] net/macb: tx status is more than 8 bits now Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 6/9] net/macb: clean up ring buffer logic Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 7/9] net/macb: ethtool interface: add register dump feature Nicolas Ferre
2012-09-19 15:14 ` Ben Hutchings
2012-09-19 11:55 ` [RFC PATCH v2 8/9] net/macb: better manage tx errors Nicolas Ferre
2012-09-19 11:55 ` [PATCH v2 9/9] net/macb: Offset first RX buffer by two bytes Nicolas Ferre
2012-09-19 17:50 ` [PATCH v2 0/9] net/macb: driver enhancement concerning GEM support, ring logic and cleanup David Miller
2012-09-20 13:03 ` Nicolas Ferre
2012-10-26 15:25 ` Nicolas Ferre
2012-10-26 18:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348067454.4836.56.camel@deadeye.wl.decadent.org.uk \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=havard@skinnemoen.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=patrice.vilchez@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®