* [PATCH] staging/rts_pstor: Delete some lines (dev_info() and dev_err()) in rtsx.c
@ 2012-09-20 11:58 YAMANE Toshiaki
0 siblings, 0 replies; only message in thread
From: YAMANE Toshiaki @ 2012-09-20 11:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Fengguang Wu, devel, Dan Carpenter, linux-kernel, YAMANE Toshiaki
fixed some coccinelle warnings.
+ drivers/staging/rts_pstor/rtsx.c:397:16-19: ERROR: dev is NULL but dereferenced.
drivers/staging/rts_pstor/rtsx.c:447:16-19: ERROR: dev is NULL but dereferenced.
drivers/staging/rts_pstor/rtsx.c:358:16-19: ERROR: dev is NULL but dereferenced.
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
---
drivers/staging/rts_pstor/rtsx.c | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c
index 213829e..afe9c2e 100644
--- a/drivers/staging/rts_pstor/rtsx.c
+++ b/drivers/staging/rts_pstor/rtsx.c
@@ -352,12 +352,8 @@ static int rtsx_suspend(struct pci_dev *pci, pm_message_t state)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;
- dev_info(&dev->pci->dev, "Ready to suspend\n");
-
- if (!dev) {
- dev_err(&dev->pci->dev, "Invalid memory\n");
+ if (!dev)
return 0;
- }
/* lock the device pointers */
mutex_lock(&(dev->dev_mutex));
@@ -391,12 +387,8 @@ static int rtsx_resume(struct pci_dev *pci)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;
- dev_info(&dev->pci->dev, "Ready to resume\n");
-
- if (!dev) {
- dev_err(&dev->pci->dev, "Invalid memory\n");
+ if (!dev)
return 0;
- }
chip = dev->chip;
@@ -441,12 +433,8 @@ static void rtsx_shutdown(struct pci_dev *pci)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;
- dev_info(&dev->pci->dev, "Ready to shutdown\n");
-
- if (!dev) {
- dev_err(&dev->pci->dev, "Invalid memory\n");
+ if (!dev)
return;
- }
chip = dev->chip;
--
1.7.9.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-20 11:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-20 11:58 [PATCH] staging/rts_pstor: Delete some lines (dev_info() and dev_err()) in rtsx.c YAMANE Toshiaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®