* [PATCH] net/phy/bcm87xx: Add MODULE_LICENSE("GPL") to GPL driver
@ 2012-09-22 2:44 Peter Huewe
2012-09-22 19:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Peter Huewe @ 2012-09-22 2:44 UTC (permalink / raw)
To: David S. Miller
Cc: Peter Korsgaard, David Daney, Christian Hohnstaedt, netdev,
linux-kernel, Peter Huewe, stable
Currently the driver has no MODULE_LICENSE attribute in its source which
results in a kernel taint if I load this:
root@(none):~# modprobe bcm87xx
bcm87xx: module license 'unspecified' taints kernel.
Since the first lines of the source code clearly state:
* This file is subject to the terms and conditions of the GNU General
* Public License. See the file "COPYING" in the main directory of this
* archive for more details.
I think it's safe to add the MODULE_LICENSE("GPL") macro and thus remove
the kernel taint.
Cc: stable@vger.kernel.org
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/net/phy/bcm87xx.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
index 2346b38..7997895 100644
--- a/drivers/net/phy/bcm87xx.c
+++ b/drivers/net/phy/bcm87xx.c
@@ -229,3 +229,5 @@ static void __exit bcm87xx_exit(void)
ARRAY_SIZE(bcm87xx_driver));
}
module_exit(bcm87xx_exit);
+
+MODULE_LICENSE("GPL");
--
1.7.8.6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/phy/bcm87xx: Add MODULE_LICENSE("GPL") to GPL driver
2012-09-22 2:44 [PATCH] net/phy/bcm87xx: Add MODULE_LICENSE("GPL") to GPL driver Peter Huewe
@ 2012-09-22 19:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-09-22 19:34 UTC (permalink / raw)
To: peterhuewe; +Cc: jacmet, david.daney, chohnstaedt, netdev, linux-kernel, stable
From: Peter Huewe <peterhuewe@gmx.de>
Date: Sat, 22 Sep 2012 04:44:18 +0200
> Currently the driver has no MODULE_LICENSE attribute in its source which
> results in a kernel taint if I load this:
>
> root@(none):~# modprobe bcm87xx
> bcm87xx: module license 'unspecified' taints kernel.
>
> Since the first lines of the source code clearly state:
> * This file is subject to the terms and conditions of the GNU General
> * Public License. See the file "COPYING" in the main directory of this
> * archive for more details.
> I think it's safe to add the MODULE_LICENSE("GPL") macro and thus remove
> the kernel taint.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Good catch, applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-22 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-22 2:44 [PATCH] net/phy/bcm87xx: Add MODULE_LICENSE("GPL") to GPL driver Peter Huewe
2012-09-22 19:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®