From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alex Dubov <oakad@yahoo.com>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: [PATCH v3 memstick: support for legacy sony memsticks
Date: Wed, 26 Sep 2012 11:48:59 +0200 [thread overview]
Message-ID: <1348652941-31899-1-git-send-email-maximlevitsky@gmail.com> (raw)
Hi,
I am sending an updated version of the driver, this time
addressing comments by Tejun Heo
Changes since V2:
* Removed the mutex kludge - ordered worqueue indeed works well
* Removed manul major/minor handling
* Gave more specific names to two sg helpers.
Changes from V1:
* Replaced explicit state numbers with enum items.
I agree that code is cleaner this way.
* Swithced to using a workqueue.
Unfortunelly, I still see that workqueue items are executed in parallel
I suspect that this happens if one work item sleeps. In this case I
don't want other work items to run too. I fixed this with a mutex, and anyway
it nice to have it to guaranteee this.
* moved sg_nents into scatterlist.c/h and put that in separate patch as
requested
* Made functions static, fixed most whitespace issues (I hope all),
and I hope addressed all other comments by Andrew Morton.
next reply other threads:[~2012-09-26 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 9:48 Maxim Levitsky [this message]
2012-09-26 9:49 ` [PATCH 1/2] scatterlist: add sg_nents Maxim Levitsky
2012-09-26 16:38 ` Tejun Heo
2012-09-27 10:47 ` Jens Axboe
2012-09-27 14:28 ` [PATCH] scatterlist: refactor the sg_nents Maxim Levitsky
2012-09-28 8:37 ` Jens Axboe
2012-10-11 10:27 ` [PATCH 1/2] scatterlist: add sg_nents Geert Uytterhoeven
2012-10-11 10:28 ` Geert Uytterhoeven
2012-09-26 9:49 ` [PATCH 2/2] memstick: add support for legacy memorysticks Maxim Levitsky
2012-09-26 16:41 ` Tejun Heo
2012-09-29 17:20 ` Geert Uytterhoeven
2012-10-01 20:24 ` Maxim Levitsky
2012-10-08 15:36 ` Fixes for ms_block Maxim Levitsky
2012-10-08 15:36 ` [PATCH 1/2] memstick: remove unused field from state struct Maxim Levitsky
2012-10-08 15:36 ` [PATCH 2/2] memstick: ms_block: fix complile issue Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348652941-31899-1-git-send-email-maximlevitsky@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome