mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alex Dubov <oakad@yahoo.com>,
	linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	Maxim Levitsky <maximlevitsky@gmail.com>
Subject: [PATCH] scatterlist: refactor the sg_nents
Date: Thu, 27 Sep 2012 16:28:37 +0200	[thread overview]
Message-ID: <1348756117-5299-1-git-send-email-maximlevitsky@gmail.com> (raw)
In-Reply-To: <50642ECB.20707@kernel.dk>

Replace 'while' with 'for' as suggested by Tejun Heo

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
 lib/scatterlist.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index 5cd9cdc..3675452b 100644
--- a/lib/scatterlist.c
+++ b/lib/scatterlist.c
@@ -49,12 +49,9 @@ EXPORT_SYMBOL(sg_next);
  **/
 int sg_nents(struct scatterlist *sg)
 {
-	int nents = 0;
-	while (sg) {
+	int nents;
+	for (nents = 0; sg; sg = sg_next(sg))
 		nents++;
-		sg = sg_next(sg);
-	}
-
 	return nents;
 }
 EXPORT_SYMBOL(sg_nents);
-- 
1.7.9.5


  reply	other threads:[~2012-09-27 14:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  9:48 [PATCH v3 memstick: support for legacy sony memsticks Maxim Levitsky
2012-09-26  9:49 ` [PATCH 1/2] scatterlist: add sg_nents Maxim Levitsky
2012-09-26 16:38   ` Tejun Heo
2012-09-27 10:47     ` Jens Axboe
2012-09-27 14:28       ` Maxim Levitsky [this message]
2012-09-28  8:37         ` [PATCH] scatterlist: refactor the sg_nents Jens Axboe
2012-10-11 10:27   ` [PATCH 1/2] scatterlist: add sg_nents Geert Uytterhoeven
2012-10-11 10:28     ` Geert Uytterhoeven
2012-09-26  9:49 ` [PATCH 2/2] memstick: add support for legacy memorysticks Maxim Levitsky
2012-09-26 16:41   ` Tejun Heo
2012-09-29 17:20   ` Geert Uytterhoeven
2012-10-01 20:24     ` Maxim Levitsky
2012-10-08 15:36     ` Fixes for ms_block Maxim Levitsky
2012-10-08 15:36       ` [PATCH 1/2] memstick: remove unused field from state struct Maxim Levitsky
2012-10-08 15:36       ` [PATCH 2/2] memstick: ms_block: fix complile issue Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348756117-5299-1-git-send-email-maximlevitsky@gmail.com \
    --to=maximlevitsky@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@yahoo.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome