* [PATCH 1/2] thermal: fair_share: Add missing static storage class specifiers
@ 2012-09-27 11:27 Sachin Kamat
2012-09-27 11:27 ` [PATCH 2/2] thermal: user_space: " Sachin Kamat
2012-09-27 11:34 ` [PATCH 1/2] thermal: fair_share: " R, Durgadoss
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2012-09-27 11:27 UTC (permalink / raw)
To: linux-kernel; +Cc: durgadoss.r, rui.zhang, sachin.kamat, patches
Fixes the following sparse warnings:
drivers/thermal/fair_share.c:80:5: warning:
symbol 'fair_share_throttle' was not declared. Should it be static?
drivers/thermal/fair_share.c:111:25: warning:
symbol 'thermal_gov_fair_share' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/thermal/fair_share.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c
index 5d3a7a3..792479f 100644
--- a/drivers/thermal/fair_share.c
+++ b/drivers/thermal/fair_share.c
@@ -77,7 +77,7 @@ static long get_target_state(struct thermal_zone_device *tz,
* (Heavily assumes the trip points are in ascending order)
* new_state of cooling device = P3 * P2 * P1
*/
-int fair_share_throttle(struct thermal_zone_device *tz, int trip)
+static int fair_share_throttle(struct thermal_zone_device *tz, int trip)
{
const struct thermal_zone_params *tzp;
struct thermal_cooling_device *cdev;
@@ -108,7 +108,7 @@ int fair_share_throttle(struct thermal_zone_device *tz, int trip)
return 0;
}
-struct thermal_governor thermal_gov_fair_share = {
+static struct thermal_governor thermal_gov_fair_share = {
.name = "fair_share",
.throttle = fair_share_throttle,
.owner = THIS_MODULE,
--
1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] thermal: user_space: Add missing static storage class specifiers
2012-09-27 11:27 [PATCH 1/2] thermal: fair_share: Add missing static storage class specifiers Sachin Kamat
@ 2012-09-27 11:27 ` Sachin Kamat
2012-09-27 11:34 ` R, Durgadoss
2012-09-27 11:34 ` [PATCH 1/2] thermal: fair_share: " R, Durgadoss
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2012-09-27 11:27 UTC (permalink / raw)
To: linux-kernel; +Cc: durgadoss.r, rui.zhang, sachin.kamat, patches
Fixes the following sparse warnings:
drivers/thermal/user_space.c:38:5: warning:
symbol 'notify_user_space' was not declared. Should it be static?
drivers/thermal/user_space.c:46:25: warning:
symbol 'thermal_gov_user_space' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/thermal/user_space.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/user_space.c b/drivers/thermal/user_space.c
index fb246b90..6bbb380 100644
--- a/drivers/thermal/user_space.c
+++ b/drivers/thermal/user_space.c
@@ -35,7 +35,7 @@
*
* This function notifies the user space through UEvents.
*/
-int notify_user_space(struct thermal_zone_device *tz, int trip)
+static int notify_user_space(struct thermal_zone_device *tz, int trip)
{
mutex_lock(&tz->lock);
kobject_uevent(&tz->device.kobj, KOBJ_CHANGE);
@@ -43,7 +43,7 @@ int notify_user_space(struct thermal_zone_device *tz, int trip)
return 0;
}
-struct thermal_governor thermal_gov_user_space = {
+static struct thermal_governor thermal_gov_user_space = {
.name = "user_space",
.throttle = notify_user_space,
.owner = THIS_MODULE,
--
1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/2] thermal: fair_share: Add missing static storage class specifiers
2012-09-27 11:27 [PATCH 1/2] thermal: fair_share: Add missing static storage class specifiers Sachin Kamat
2012-09-27 11:27 ` [PATCH 2/2] thermal: user_space: " Sachin Kamat
@ 2012-09-27 11:34 ` R, Durgadoss
1 sibling, 0 replies; 4+ messages in thread
From: R, Durgadoss @ 2012-09-27 11:34 UTC (permalink / raw)
To: Sachin Kamat, linux-kernel; +Cc: Zhang, Rui, patches
> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
> Sent: Thursday, September 27, 2012 4:58 PM
> To: linux-kernel@vger.kernel.org
> Cc: R, Durgadoss; Zhang, Rui; sachin.kamat@linaro.org; patches@linaro.org
> Subject: [PATCH 1/2] thermal: fair_share: Add missing static storage class
> specifiers
>
> Fixes the following sparse warnings:
> drivers/thermal/fair_share.c:80:5: warning:
> symbol 'fair_share_throttle' was not declared. Should it be static?
> drivers/thermal/fair_share.c:111:25: warning:
> symbol 'thermal_gov_fair_share' was not declared. Should it be static?
>
Looks fine.
Acked-by: Durgadoss R <Durgadoss.r@intel.com>
Thanks,
Durga
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/thermal/fair_share.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c
> index 5d3a7a3..792479f 100644
> --- a/drivers/thermal/fair_share.c
> +++ b/drivers/thermal/fair_share.c
> @@ -77,7 +77,7 @@ static long get_target_state(struct
> thermal_zone_device *tz,
> * (Heavily assumes the trip points are in ascending order)
> * new_state of cooling device = P3 * P2 * P1
> */
> -int fair_share_throttle(struct thermal_zone_device *tz, int trip)
> +static int fair_share_throttle(struct thermal_zone_device *tz, int trip)
> {
> const struct thermal_zone_params *tzp;
> struct thermal_cooling_device *cdev;
> @@ -108,7 +108,7 @@ int fair_share_throttle(struct thermal_zone_device
> *tz, int trip)
> return 0;
> }
>
> -struct thermal_governor thermal_gov_fair_share = {
> +static struct thermal_governor thermal_gov_fair_share = {
> .name = "fair_share",
> .throttle = fair_share_throttle,
> .owner = THIS_MODULE,
> --
> 1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 2/2] thermal: user_space: Add missing static storage class specifiers
2012-09-27 11:27 ` [PATCH 2/2] thermal: user_space: " Sachin Kamat
@ 2012-09-27 11:34 ` R, Durgadoss
0 siblings, 0 replies; 4+ messages in thread
From: R, Durgadoss @ 2012-09-27 11:34 UTC (permalink / raw)
To: Sachin Kamat, linux-kernel; +Cc: Zhang, Rui, patches
> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
> Sent: Thursday, September 27, 2012 4:58 PM
> To: linux-kernel@vger.kernel.org
> Cc: R, Durgadoss; Zhang, Rui; sachin.kamat@linaro.org; patches@linaro.org
> Subject: [PATCH 2/2] thermal: user_space: Add missing static storage class
> specifiers
>
> Fixes the following sparse warnings:
> drivers/thermal/user_space.c:38:5: warning:
> symbol 'notify_user_space' was not declared. Should it be static?
> drivers/thermal/user_space.c:46:25: warning:
> symbol 'thermal_gov_user_space' was not declared. Should it be static?
Looks fine. Thanks for the two patches :-)
Acked-by: Durgadoss R <durgadoss.r@intel.com>
Thanks,
Durga
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/thermal/user_space.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/user_space.c b/drivers/thermal/user_space.c
> index fb246b90..6bbb380 100644
> --- a/drivers/thermal/user_space.c
> +++ b/drivers/thermal/user_space.c
> @@ -35,7 +35,7 @@
> *
> * This function notifies the user space through UEvents.
> */
> -int notify_user_space(struct thermal_zone_device *tz, int trip)
> +static int notify_user_space(struct thermal_zone_device *tz, int trip)
> {
> mutex_lock(&tz->lock);
> kobject_uevent(&tz->device.kobj, KOBJ_CHANGE);
> @@ -43,7 +43,7 @@ int notify_user_space(struct thermal_zone_device *tz,
> int trip)
> return 0;
> }
>
> -struct thermal_governor thermal_gov_user_space = {
> +static struct thermal_governor thermal_gov_user_space = {
> .name = "user_space",
> .throttle = notify_user_space,
> .owner = THIS_MODULE,
> --
> 1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-27 11:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-27 11:27 [PATCH 1/2] thermal: fair_share: Add missing static storage class specifiers Sachin Kamat
2012-09-27 11:27 ` [PATCH 2/2] thermal: user_space: " Sachin Kamat
2012-09-27 11:34 ` R, Durgadoss
2012-09-27 11:34 ` [PATCH 1/2] thermal: fair_share: " R, Durgadoss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®