From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Andy Whitcroft <apw@canonical.com>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Probable false positive in checkpatch
Date: Fri, 28 Sep 2012 13:59:17 -0700 [thread overview]
Message-ID: <1348865957.14262.46.camel@joe-AO722> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1209281546480.1164-100000@iolanthe.rowland.org>
On Fri, 2012-09-28 at 15:50 -0400, Alan Stern wrote:
> Here's what I just got from checkpatch:
>
> ERROR: space prohibited after that '-' (ctx:BxW)
> #22: FILE: drivers/usb/host/ehci-sched.c:1419:
> + start += (next - start + period - 1) & (- period);
> ^
> This seems unlikely to be a real style violation. Or if it is, maybe
> it shouldn't be. After all, "(0 - period)" would be okay.
2c: I think the recommendation is proper and correct.
next prev parent reply other threads:[~2012-09-28 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 19:50 Alan Stern
2012-09-28 20:59 ` Joe Perches [this message]
2012-09-29 1:53 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348865957.14262.46.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®