* Probable false positive in checkpatch
@ 2012-09-28 19:50 Alan Stern
2012-09-28 20:59 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2012-09-28 19:50 UTC (permalink / raw)
To: Andy Whitcroft; +Cc: Kernel development list
Andy:
Here's what I just got from checkpatch:
ERROR: space prohibited after that '-' (ctx:BxW)
#22: FILE: drivers/usb/host/ehci-sched.c:1419:
+ start += (next - start + period - 1) & (- period);
^
This seems unlikely to be a real style violation. Or if it is, maybe
it shouldn't be. After all, "(0 - period)" would be okay.
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Probable false positive in checkpatch
2012-09-28 19:50 Probable false positive in checkpatch Alan Stern
@ 2012-09-28 20:59 ` Joe Perches
2012-09-29 1:53 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2012-09-28 20:59 UTC (permalink / raw)
To: Alan Stern; +Cc: Andy Whitcroft, Kernel development list
On Fri, 2012-09-28 at 15:50 -0400, Alan Stern wrote:
> Here's what I just got from checkpatch:
>
> ERROR: space prohibited after that '-' (ctx:BxW)
> #22: FILE: drivers/usb/host/ehci-sched.c:1419:
> + start += (next - start + period - 1) & (- period);
> ^
> This seems unlikely to be a real style violation. Or if it is, maybe
> it shouldn't be. After all, "(0 - period)" would be okay.
2c: I think the recommendation is proper and correct.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Probable false positive in checkpatch
2012-09-28 20:59 ` Joe Perches
@ 2012-09-29 1:53 ` Alan Stern
0 siblings, 0 replies; 3+ messages in thread
From: Alan Stern @ 2012-09-29 1:53 UTC (permalink / raw)
To: Joe Perches; +Cc: Andy Whitcroft, Kernel development list
On Fri, 28 Sep 2012, Joe Perches wrote:
> On Fri, 2012-09-28 at 15:50 -0400, Alan Stern wrote:
> > Here's what I just got from checkpatch:
> >
> > ERROR: space prohibited after that '-' (ctx:BxW)
> > #22: FILE: drivers/usb/host/ehci-sched.c:1419:
> > + start += (next - start + period - 1) & (- period);
> > ^
> > This seems unlikely to be a real style violation. Or if it is, maybe
> > it shouldn't be. After all, "(0 - period)" would be okay.
>
> 2c: I think the recommendation is proper and correct.
I just looked in CodingStyle, and sure enough, there it is in section
3.1. The complaint is hereby withdrawn.
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-29 1:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-28 19:50 Probable false positive in checkpatch Alan Stern
2012-09-28 20:59 ` Joe Perches
2012-09-29 1:53 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®