From: Ben Hutchings <ben@decadent.org.uk>
To: Michael Tokarev <mjt@tls.msk.ru>, David Miller <davem@davemloft.net>
Cc: Ferenc Wagner <wferi@niif.hu>, Michael Chan <mchan@broadcom.com>,
netdev@vger.kernel.org, Matt Carlson <mcarlson@broadcom.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: tg3 driver upgrade (Linux 2.6.32 -> 3.2) breaks IBM Bladecenter SoL
Date: Wed, 03 Oct 2012 01:17:12 +0100 [thread overview]
Message-ID: <1349223432.16173.10.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <506B3B52.7080001@msgid.tls.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Tue, 2012-10-02 at 23:06 +0400, Michael Tokarev wrote:
> On 02.10.2012 22:49, Ferenc Wagner wrote:
> > "Michael Chan" <mchan@broadcom.com> writes:
> >> These are the likely fixes:
> >>
> >> commit cf9ecf4b631f649a964fa611f1a5e8874f2a76db
> >> Author: Matt Carlson <mcarlson@broadcom.com>
> >> Date: Mon Nov 28 09:41:03 2011 +0000
> >>
> >> tg3: Fix TSO CAP for 5704 devs w / ASF enabled
> >
> > You are exactly right: cf9ecf4b fixed the premanent SoL breakage
> > introduced by dabc5c67. Looks like ASF utilizes similar technology to
> > that of the HS20 BMC. Thanks for the tip, it greatly reduced our CPU
> > wear. :) It's a pity ethtool -k did not give a hint. Do you think it's
> > possible to work around in 3.2 by eg. fiddling some ethtool setting?
>
> Maybe it's better to push this commit to -stable instead?
But that will take time, so I imagine a temporary workaround would be
useful to Ferenc.
> (the commit
> that broke things is part of 3.0 kernel so all current 3.x -stable
> kernels are affected)
[...]
The fix went into 3.3, so only 3.0 and 3.2 need it.
David, please can you include the above commit in your next batches for
these stable series?
Ben.
--
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-10-03 0:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 20:45 Ferenc Wagner
2012-10-01 9:33 ` Michael Chan
2012-10-02 9:31 ` Ferenc Wagner
2012-10-02 12:07 ` Ferenc Wagner
2012-10-02 15:03 ` Michael Chan
2012-10-02 16:49 ` Ferenc Wagner
2012-10-02 17:06 ` Michael Chan
2012-10-02 18:49 ` Ferenc Wagner
2012-10-02 19:06 ` Michael Tokarev
2012-10-03 0:17 ` Ben Hutchings [this message]
2012-10-03 0:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349223432.16173.10.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=mjt@tls.msk.ru \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=stable@vger.kernel.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®